You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/07/02 15:32:23 UTC
[GitHub] [incubator-openwhisk] rabbah commented on a change in pull request
#4535: Handle deleted limits document for get operation the same way as
missing limits document
rabbah commented on a change in pull request #4535: Handle deleted limits document for get operation the same way as missing limits document
URL: https://github.com/apache/incubator-openwhisk/pull/4535#discussion_r299547490
##########
File path: tools/admin/wskadmin
##########
@@ -576,7 +576,7 @@ def getLimitsCmd(args, props):
print('No limits found, default system limits apply')
else:
print('Failed to get limits (%s)' % res.read().strip())
- return 1
+ return 1
Review comment:
can you cover all three exits? return 0 at line 576, and leave return 1 on 579?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services