You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by de...@apache.org on 2017/08/06 05:52:43 UTC
svn commit: r1804224 -
/ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/ofbiz/birt/flexible/BirtUtil.java
Author: deepak
Date: Sun Aug 6 05:52:43 2017
New Revision: 1804224
URL: http://svn.apache.org/viewvc?rev=1804224&view=rev
Log:
Improved: Removed ne references from BirtUtil class file (OFBIZ-9351)
Thanks Aditya for your contribution.
I removed them but forgot to commit :)
Modified:
ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/ofbiz/birt/flexible/BirtUtil.java
Modified: ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/ofbiz/birt/flexible/BirtUtil.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/ofbiz/birt/flexible/BirtUtil.java?rev=1804224&r1=1804223&r2=1804224&view=diff
==============================================================================
--- ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/ofbiz/birt/flexible/BirtUtil.java (original)
+++ ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/ofbiz/birt/flexible/BirtUtil.java Sun Aug 6 05:52:43 2017
@@ -47,7 +47,7 @@ public final class BirtUtil {
"id", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
"url", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
"name", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
- "id-ne", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
+ "id", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
"value", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
"email", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
"comment", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
@@ -57,8 +57,8 @@ public final class BirtUtil {
"indicator", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
"very-short", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
"tel-number", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
- "id-long-ne", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
- "id-vlong-ne", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
+ "id-long", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
+ "id-vlong", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
"description", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
"long-varchar", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
"short-varchar", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
@@ -79,7 +79,7 @@ public final class BirtUtil {
"id", DesignChoiceConstants.PARAM_TYPE_STRING,
"url", DesignChoiceConstants.PARAM_TYPE_STRING,
"name", DesignChoiceConstants.PARAM_TYPE_STRING,
- "id-ne", DesignChoiceConstants.PARAM_TYPE_STRING,
+ "id", DesignChoiceConstants.PARAM_TYPE_STRING,
"value", DesignChoiceConstants.PARAM_TYPE_STRING,
"email", DesignChoiceConstants.PARAM_TYPE_STRING,
"comment", DesignChoiceConstants.PARAM_TYPE_STRING,
@@ -89,8 +89,8 @@ public final class BirtUtil {
"indicator", DesignChoiceConstants.PARAM_TYPE_STRING,
"very-short", DesignChoiceConstants.PARAM_TYPE_STRING,
"tel-number", DesignChoiceConstants.PARAM_TYPE_STRING,
- "id-long-ne", DesignChoiceConstants.PARAM_TYPE_STRING,
- "id-vlong-ne", DesignChoiceConstants.PARAM_TYPE_STRING,
+ "id-long", DesignChoiceConstants.PARAM_TYPE_STRING,
+ "id-vlong", DesignChoiceConstants.PARAM_TYPE_STRING,
"description", DesignChoiceConstants.PARAM_TYPE_STRING,
"long-varchar", DesignChoiceConstants.PARAM_TYPE_STRING,
"short-varchar", DesignChoiceConstants.PARAM_TYPE_STRING,
Re: svn commit: r1804224 - /ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/ofbiz/birt/flexible/BirtUtil.java
Posted by Deepak Dixit <de...@hotwaxsystems.com>.
Thanks Aditya, this has been done at r#1804487
Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
www.hotwax.co
On Sun, Aug 6, 2017 at 1:07 PM, Aditya Sharma <
aditya.sharma@hotwaxsystems.com> wrote:
> Pardon me for the typo *Deepak
>
> Thanks and Regards,
>
> *Aditya Sharma* | Enterprise Software Engineer
> HotWax Systems <http://www.hotwaxsystems.com/>
> <https://www.linkedin.com/in/aditya-sharma-78291810a/>
>
> On Sun, Aug 6, 2017 at 1:01 PM, Aditya Sharma <aditya.sharma@hotwaxsystems.
> com> wrote:
>
> > Hi Depak,
> >
> > I think we can just remove these lines instead of replacing them as these
> > field types are already mapped with Birt data type & got redundant now.
> >
> > private final static Map<String, String> entityFieldTypeBirtTypeMap =
> > MapUtils.unmodifiableMap(UtilMisc.toMap(
> > *"id", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,*
> > "url", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> > "name", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> > * "id", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,*
> > "value", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> > "email", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> > "comment", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> > * "id-long",DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,*
> > * "id-vlong", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,*
> > "very-long", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> > "indicator", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> > "very-short", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> > "tel-number", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> > * "id-long", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,*
> > * "id-vlong", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,*
> > "description", DesignChoiceConstants.COLUMN_
> DATA_TYPE_STRING,
> > "long-varchar", DesignChoiceConstants.COLUMN_
> DATA_TYPE_STRING,
> > "short-varchar", DesignChoiceConstants.COLUMN_D
> > ATA_TYPE_STRING,
> > "credit-card-date", DesignChoiceConstants.COLUMN_D
> > ATA_TYPE_STRING,
> > "credit-card-number", DesignChoiceConstants.COLUMN_D
> > ATA_TYPE_STRING,
> > "date-time", DesignChoiceConstants.COLUMN_
> DATA_TYPE_DATETIME,
> > "date", DesignChoiceConstants.COLUMN_DATA_TYPE_DATE,
> > "time", DesignChoiceConstants.COLUMN_DATA_TYPE_TIME,
> > "currency-amount", DesignChoiceConstants.COLUMN_D
> > ATA_TYPE_DECIMAL,
> > "currency-precise", DesignChoiceConstants.COLUMN_D
> > ATA_TYPE_DECIMAL,
> > "fixed-point", DesignChoiceConstants.COLUMN_
> DATA_TYPE_DECIMAL,
> > "floating-point", DesignChoiceConstants.COLUMN_D
> > ATA_TYPE_DECIMAL,
> > "numeric", DesignChoiceConstants.COLUMN_DATA_TYPE_INTEGER,
> > "object", DesignChoiceConstants.COLUMN_
> DATA_TYPE_JAVA_OBJECT,
> > "blob", DesignChoiceConstants.COLUMN_DATA_TYPE_BLOB));
> >
> > Thanks and Regards,
> >
> > *Aditya Sharma* | Enterprise Software Engineer
> > HotWax Systems <http://www.hotwaxsystems.com/>
> > <https://www.linkedin.com/in/aditya-sharma-78291810a/>
> >
> > On Sun, Aug 6, 2017 at 11:22 AM, <de...@apache.org> wrote:
> >
> >> Author: deepak
> >> Date: Sun Aug 6 05:52:43 2017
> >> New Revision: 1804224
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1804224&view=rev
> >> Log:
> >> Improved: Removed ne references from BirtUtil class file (OFBIZ-9351)
> >> Thanks Aditya for your contribution.
> >> I removed them but forgot to commit :)
> >>
> >> Modified:
> >> ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/ofbi
> >> z/birt/flexible/BirtUtil.java
> >>
> >> Modified: ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/ofbi
> >> z/birt/flexible/BirtUtil.java
> >> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/birt/
> >> src/main/java/org/apache/ofbiz/birt/flexible/BirtUtil.java?r
> >> ev=1804224&r1=1804223&r2=1804224&view=diff
> >> ============================================================
> >> ==================
> >> --- ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/
> ofbiz/birt/flexible/BirtUtil.java
> >> (original)
> >> +++ ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/
> ofbiz/birt/flexible/BirtUtil.java
> >> Sun Aug 6 05:52:43 2017
> >> @@ -47,7 +47,7 @@ public final class BirtUtil {
> >> "id", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> >> "url", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> >> "name", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> >> - "id-ne", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> >> + "id", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> >> "value", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> >> "email", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> >> "comment", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> >> @@ -57,8 +57,8 @@ public final class BirtUtil {
> >> "indicator", DesignChoiceConstants.COLUMN_
> DATA_TYPE_STRING,
> >> "very-short", DesignChoiceConstants.COLUMN_
> DATA_TYPE_STRING,
> >> "tel-number", DesignChoiceConstants.COLUMN_
> DATA_TYPE_STRING,
> >> - "id-long-ne", DesignChoiceConstants.COLUMN_
> DATA_TYPE_STRING,
> >> - "id-vlong-ne", DesignChoiceConstants.COLUMN_D
> >> ATA_TYPE_STRING,
> >> + "id-long", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> >> + "id-vlong", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> >> "description", DesignChoiceConstants.COLUMN_D
> >> ATA_TYPE_STRING,
> >> "long-varchar", DesignChoiceConstants.COLUMN_D
> >> ATA_TYPE_STRING,
> >> "short-varchar", DesignChoiceConstants.COLUMN_D
> >> ATA_TYPE_STRING,
> >> @@ -79,7 +79,7 @@ public final class BirtUtil {
> >> "id", DesignChoiceConstants.PARAM_TYPE_STRING,
> >> "url", DesignChoiceConstants.PARAM_TYPE_STRING,
> >> "name", DesignChoiceConstants.PARAM_TYPE_STRING,
> >> - "id-ne", DesignChoiceConstants.PARAM_TYPE_STRING,
> >> + "id", DesignChoiceConstants.PARAM_TYPE_STRING,
> >> "value", DesignChoiceConstants.PARAM_TYPE_STRING,
> >> "email", DesignChoiceConstants.PARAM_TYPE_STRING,
> >> "comment", DesignChoiceConstants.PARAM_TYPE_STRING,
> >> @@ -89,8 +89,8 @@ public final class BirtUtil {
> >> "indicator", DesignChoiceConstants.PARAM_TYPE_STRING,
> >> "very-short", DesignChoiceConstants.PARAM_TYPE_STRING,
> >> "tel-number", DesignChoiceConstants.PARAM_TYPE_STRING,
> >> - "id-long-ne", DesignChoiceConstants.PARAM_TYPE_STRING,
> >> - "id-vlong-ne", DesignChoiceConstants.PARAM_TYPE_STRING,
> >> + "id-long", DesignChoiceConstants.PARAM_TYPE_STRING,
> >> + "id-vlong", DesignChoiceConstants.PARAM_TYPE_STRING,
> >> "description", DesignChoiceConstants.PARAM_TYPE_STRING,
> >> "long-varchar", DesignChoiceConstants.PARAM_TYPE_STRING,
> >> "short-varchar", DesignChoiceConstants.PARAM_TYPE_STRING,
> >>
> >>
> >>
> >
>
Re: svn commit: r1804224 - /ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/ofbiz/birt/flexible/BirtUtil.java
Posted by Aditya Sharma <ad...@hotwaxsystems.com>.
Pardon me for the typo *Deepak
Thanks and Regards,
*Aditya Sharma* | Enterprise Software Engineer
HotWax Systems <http://www.hotwaxsystems.com/>
<https://www.linkedin.com/in/aditya-sharma-78291810a/>
On Sun, Aug 6, 2017 at 1:01 PM, Aditya Sharma <aditya.sharma@hotwaxsystems.
com> wrote:
> Hi Depak,
>
> I think we can just remove these lines instead of replacing them as these
> field types are already mapped with Birt data type & got redundant now.
>
> private final static Map<String, String> entityFieldTypeBirtTypeMap =
> MapUtils.unmodifiableMap(UtilMisc.toMap(
> *"id", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,*
> "url", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> "name", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> * "id", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,*
> "value", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> "email", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> "comment", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> * "id-long",DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,*
> * "id-vlong", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,*
> "very-long", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> "indicator", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> "very-short", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> "tel-number", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> * "id-long", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,*
> * "id-vlong", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,*
> "description", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> "long-varchar", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> "short-varchar", DesignChoiceConstants.COLUMN_D
> ATA_TYPE_STRING,
> "credit-card-date", DesignChoiceConstants.COLUMN_D
> ATA_TYPE_STRING,
> "credit-card-number", DesignChoiceConstants.COLUMN_D
> ATA_TYPE_STRING,
> "date-time", DesignChoiceConstants.COLUMN_DATA_TYPE_DATETIME,
> "date", DesignChoiceConstants.COLUMN_DATA_TYPE_DATE,
> "time", DesignChoiceConstants.COLUMN_DATA_TYPE_TIME,
> "currency-amount", DesignChoiceConstants.COLUMN_D
> ATA_TYPE_DECIMAL,
> "currency-precise", DesignChoiceConstants.COLUMN_D
> ATA_TYPE_DECIMAL,
> "fixed-point", DesignChoiceConstants.COLUMN_DATA_TYPE_DECIMAL,
> "floating-point", DesignChoiceConstants.COLUMN_D
> ATA_TYPE_DECIMAL,
> "numeric", DesignChoiceConstants.COLUMN_DATA_TYPE_INTEGER,
> "object", DesignChoiceConstants.COLUMN_DATA_TYPE_JAVA_OBJECT,
> "blob", DesignChoiceConstants.COLUMN_DATA_TYPE_BLOB));
>
> Thanks and Regards,
>
> *Aditya Sharma* | Enterprise Software Engineer
> HotWax Systems <http://www.hotwaxsystems.com/>
> <https://www.linkedin.com/in/aditya-sharma-78291810a/>
>
> On Sun, Aug 6, 2017 at 11:22 AM, <de...@apache.org> wrote:
>
>> Author: deepak
>> Date: Sun Aug 6 05:52:43 2017
>> New Revision: 1804224
>>
>> URL: http://svn.apache.org/viewvc?rev=1804224&view=rev
>> Log:
>> Improved: Removed ne references from BirtUtil class file (OFBIZ-9351)
>> Thanks Aditya for your contribution.
>> I removed them but forgot to commit :)
>>
>> Modified:
>> ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/ofbi
>> z/birt/flexible/BirtUtil.java
>>
>> Modified: ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/ofbi
>> z/birt/flexible/BirtUtil.java
>> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/birt/
>> src/main/java/org/apache/ofbiz/birt/flexible/BirtUtil.java?r
>> ev=1804224&r1=1804223&r2=1804224&view=diff
>> ============================================================
>> ==================
>> --- ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/ofbiz/birt/flexible/BirtUtil.java
>> (original)
>> +++ ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/ofbiz/birt/flexible/BirtUtil.java
>> Sun Aug 6 05:52:43 2017
>> @@ -47,7 +47,7 @@ public final class BirtUtil {
>> "id", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
>> "url", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
>> "name", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
>> - "id-ne", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
>> + "id", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
>> "value", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
>> "email", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
>> "comment", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
>> @@ -57,8 +57,8 @@ public final class BirtUtil {
>> "indicator", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
>> "very-short", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
>> "tel-number", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
>> - "id-long-ne", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
>> - "id-vlong-ne", DesignChoiceConstants.COLUMN_D
>> ATA_TYPE_STRING,
>> + "id-long", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
>> + "id-vlong", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
>> "description", DesignChoiceConstants.COLUMN_D
>> ATA_TYPE_STRING,
>> "long-varchar", DesignChoiceConstants.COLUMN_D
>> ATA_TYPE_STRING,
>> "short-varchar", DesignChoiceConstants.COLUMN_D
>> ATA_TYPE_STRING,
>> @@ -79,7 +79,7 @@ public final class BirtUtil {
>> "id", DesignChoiceConstants.PARAM_TYPE_STRING,
>> "url", DesignChoiceConstants.PARAM_TYPE_STRING,
>> "name", DesignChoiceConstants.PARAM_TYPE_STRING,
>> - "id-ne", DesignChoiceConstants.PARAM_TYPE_STRING,
>> + "id", DesignChoiceConstants.PARAM_TYPE_STRING,
>> "value", DesignChoiceConstants.PARAM_TYPE_STRING,
>> "email", DesignChoiceConstants.PARAM_TYPE_STRING,
>> "comment", DesignChoiceConstants.PARAM_TYPE_STRING,
>> @@ -89,8 +89,8 @@ public final class BirtUtil {
>> "indicator", DesignChoiceConstants.PARAM_TYPE_STRING,
>> "very-short", DesignChoiceConstants.PARAM_TYPE_STRING,
>> "tel-number", DesignChoiceConstants.PARAM_TYPE_STRING,
>> - "id-long-ne", DesignChoiceConstants.PARAM_TYPE_STRING,
>> - "id-vlong-ne", DesignChoiceConstants.PARAM_TYPE_STRING,
>> + "id-long", DesignChoiceConstants.PARAM_TYPE_STRING,
>> + "id-vlong", DesignChoiceConstants.PARAM_TYPE_STRING,
>> "description", DesignChoiceConstants.PARAM_TYPE_STRING,
>> "long-varchar", DesignChoiceConstants.PARAM_TYPE_STRING,
>> "short-varchar", DesignChoiceConstants.PARAM_TYPE_STRING,
>>
>>
>>
>
Re: svn commit: r1804224 - /ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/ofbiz/birt/flexible/BirtUtil.java
Posted by Aditya Sharma <ad...@hotwaxsystems.com>.
Hi Depak,
I think we can just remove these lines instead of replacing them as these
field types are already mapped with Birt data type & got redundant now.
private final static Map<String, String> entityFieldTypeBirtTypeMap =
MapUtils.unmodifiableMap(UtilMisc.toMap(
*"id", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,*
"url", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
"name", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
* "id", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,*
"value", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
"email", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
"comment", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
* "id-long",DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,*
* "id-vlong", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,*
"very-long", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
"indicator", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
"very-short", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
"tel-number", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
* "id-long", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,*
* "id-vlong", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,*
"description", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
"long-varchar", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
"short-varchar", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
"credit-card-date",
DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
"credit-card-number",
DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
"date-time", DesignChoiceConstants.COLUMN_DATA_TYPE_DATETIME,
"date", DesignChoiceConstants.COLUMN_DATA_TYPE_DATE,
"time", DesignChoiceConstants.COLUMN_DATA_TYPE_TIME,
"currency-amount",
DesignChoiceConstants.COLUMN_DATA_TYPE_DECIMAL,
"currency-precise",
DesignChoiceConstants.COLUMN_DATA_TYPE_DECIMAL,
"fixed-point", DesignChoiceConstants.COLUMN_DATA_TYPE_DECIMAL,
"floating-point",
DesignChoiceConstants.COLUMN_DATA_TYPE_DECIMAL,
"numeric", DesignChoiceConstants.COLUMN_DATA_TYPE_INTEGER,
"object", DesignChoiceConstants.COLUMN_DATA_TYPE_JAVA_OBJECT,
"blob", DesignChoiceConstants.COLUMN_DATA_TYPE_BLOB));
Thanks and Regards,
*Aditya Sharma* | Enterprise Software Engineer
HotWax Systems <http://www.hotwaxsystems.com/>
<https://www.linkedin.com/in/aditya-sharma-78291810a/>
On Sun, Aug 6, 2017 at 11:22 AM, <de...@apache.org> wrote:
> Author: deepak
> Date: Sun Aug 6 05:52:43 2017
> New Revision: 1804224
>
> URL: http://svn.apache.org/viewvc?rev=1804224&view=rev
> Log:
> Improved: Removed ne references from BirtUtil class file (OFBIZ-9351)
> Thanks Aditya for your contribution.
> I removed them but forgot to commit :)
>
> Modified:
> ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/
> ofbiz/birt/flexible/BirtUtil.java
>
> Modified: ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/
> ofbiz/birt/flexible/BirtUtil.java
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/
> birt/src/main/java/org/apache/ofbiz/birt/flexible/BirtUtil.
> java?rev=1804224&r1=1804223&r2=1804224&view=diff
> ============================================================
> ==================
> --- ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/
> ofbiz/birt/flexible/BirtUtil.java (original)
> +++ ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/
> ofbiz/birt/flexible/BirtUtil.java Sun Aug 6 05:52:43 2017
> @@ -47,7 +47,7 @@ public final class BirtUtil {
> "id", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> "url", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> "name", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> - "id-ne", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> + "id", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> "value", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> "email", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> "comment", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> @@ -57,8 +57,8 @@ public final class BirtUtil {
> "indicator", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> "very-short", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> "tel-number", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> - "id-long-ne", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> - "id-vlong-ne", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> + "id-long", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> + "id-vlong", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> "description", DesignChoiceConstants.COLUMN_DATA_TYPE_STRING,
> "long-varchar", DesignChoiceConstants.COLUMN_
> DATA_TYPE_STRING,
> "short-varchar", DesignChoiceConstants.COLUMN_
> DATA_TYPE_STRING,
> @@ -79,7 +79,7 @@ public final class BirtUtil {
> "id", DesignChoiceConstants.PARAM_TYPE_STRING,
> "url", DesignChoiceConstants.PARAM_TYPE_STRING,
> "name", DesignChoiceConstants.PARAM_TYPE_STRING,
> - "id-ne", DesignChoiceConstants.PARAM_TYPE_STRING,
> + "id", DesignChoiceConstants.PARAM_TYPE_STRING,
> "value", DesignChoiceConstants.PARAM_TYPE_STRING,
> "email", DesignChoiceConstants.PARAM_TYPE_STRING,
> "comment", DesignChoiceConstants.PARAM_TYPE_STRING,
> @@ -89,8 +89,8 @@ public final class BirtUtil {
> "indicator", DesignChoiceConstants.PARAM_TYPE_STRING,
> "very-short", DesignChoiceConstants.PARAM_TYPE_STRING,
> "tel-number", DesignChoiceConstants.PARAM_TYPE_STRING,
> - "id-long-ne", DesignChoiceConstants.PARAM_TYPE_STRING,
> - "id-vlong-ne", DesignChoiceConstants.PARAM_TYPE_STRING,
> + "id-long", DesignChoiceConstants.PARAM_TYPE_STRING,
> + "id-vlong", DesignChoiceConstants.PARAM_TYPE_STRING,
> "description", DesignChoiceConstants.PARAM_TYPE_STRING,
> "long-varchar", DesignChoiceConstants.PARAM_TYPE_STRING,
> "short-varchar", DesignChoiceConstants.PARAM_TYPE_STRING,
>
>
>