You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/03/23 11:49:28 UTC

[GitHub] [servicecomb-java-chassis] Shoothzj opened a new pull request #2745: add jakarta dependency in foundation-config

Shoothzj opened a new pull request #2745:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2745


   java later version has removed `javax.annotation` dependency. If we need to support multi java versions, we need to add `jakarta` dependecy


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [servicecomb-java-chassis] Shoothzj commented on pull request #2745: [SCB-2428] add jakarta dependency in foundation-config

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #2745:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2745#issuecomment-1077042610


   @liubao68 when compile using java 17
   <img width="1662" alt="image" src="https://user-images.githubusercontent.com/12933197/159839310-fbe99938-8579-4bc0-be61-56a9729598c4.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2745: [SCB-2428] add jakarta dependency in foundation-config

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2745:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2745#discussion_r833894596



##########
File path: foundations/foundation-config/pom.xml
##########
@@ -51,6 +51,10 @@
       <groupId>org.yaml</groupId>
       <artifactId>snakeyaml</artifactId>
     </dependency>
+    <dependency>
+      <groupId>jakarta.annotation</groupId>
+      <artifactId>jakarta.annotation-api</artifactId>
+    </dependency>

Review comment:
       Why add this dependency? Can you provide the problem?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #2745: [SCB-2428] add jakarta dependency in foundation-config

Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #2745:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2745


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org