[GitHub] [spark] ulysses-you commented on a change in pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly

[GitBox <gi...@apache.org>]

ulysses-you commented on a change in pull request #28808:
URL: https://github.com/apache/spark/pull/28808#discussion_r449028610



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -158,6 +158,9 @@ trait CheckAnalysis extends PredicateHelper {
           case g: GroupingID =>
             failAnalysis("grouping_id() can only be used with GroupingSets/Cube/Rollup")
 
+          case Alias(w: WindowFunction, _) =>
+            failAnalysis(s"Window function $w call requires an OVER clause.")

Review comment:
       removed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org