You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/16 02:41:22 UTC
[GitHub] [flink] JingsongLi commented on a change in pull request #9120:
[FLINK-13216][FLINK-13153][table-planner-blink] Fix Max_Retract and
Min_Retract may produce incorrect result
JingsongLi commented on a change in pull request #9120: [FLINK-13216][FLINK-13153][table-planner-blink] Fix Max_Retract and Min_Retract may produce incorrect result
URL: https://github.com/apache/flink/pull/9120#discussion_r303708438
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/functions/aggfunctions/MaxWithRetractAggFunction.java
##########
@@ -135,6 +135,8 @@ private void updateMax(MaxWithRetractAccumulator<T> acc) throws Exception {
// when both of them are expired.
Review comment:
I am confused about this comments, expired?
If it is an empty map, why there is a max?
Should set max to null at the moment of becoming empty?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services