You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "dependabot[bot] (via GitHub)" <gi...@apache.org> on 2025/04/24 17:20:05 UTC
[PR] Bump react-router and react-router-dom in /pinot-controller/src/main/resources [pinot]
dependabot[bot] opened a new pull request, #15635:
URL: https://github.com/apache/pinot/pull/15635
Removes [react-router](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router). It's no longer used after updating ancestor dependency [react-router-dom](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom). These dependencies need to be updated together.
Removes `react-router`
Updates `react-router-dom` from 5.3.3 to 7.5.2
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/remix-run/react-router/releases">react-router-dom's releases</a>.</em></p>
<blockquote>
<h2>v7.1.3</h2>
<p>See the changelog for release notes: <a href="https://github.com/remix-run/react-router/blob/main/CHANGELOG.md#v713">https://github.com/remix-run/react-router/blob/main/CHANGELOG.md#v713</a></p>
<h2>v6.4.4</h2>
<h2>What's Changed</h2>
<ul>
<li>Throw an error if an <code>action</code>/<code>loader</code> function returns <code>undefined</code> as revalidations need to know whether the loader has previously been executed. <code>undefined</code> also causes issues during SSR stringification for hydration. You should always ensure your <code>loader</code>/<code>action</code> returns a value, and you may return <code>null</code> if you don't wish to return anything. (<a href="https://redirect.github.com/remix-run/react-router/pull/9511">#9511</a>)</li>
<li>Properly handle redirects to external domains (<a href="https://redirect.github.com/remix-run/react-router/pull/9590">#9590</a>, <a href="https://redirect.github.com/remix-run/react-router/pull/9654">#9654</a>)</li>
<li>Preserve the HTTP method on 307/308 redirects (<a href="https://redirect.github.com/remix-run/react-router/pull/9597">#9597</a>)</li>
<li>Support <code>basename</code> in static data routers (<a href="https://redirect.github.com/remix-run/react-router/pull/9591">#9591</a>)</li>
<li>Enhanced <code>ErrorResponse</code> bodies to contain more descriptive text in internal 403/404/405 scenarios</li>
<li>Fix issues with encoded characters in <code>NavLink</code> and descendant <code><Routes></code> (<a href="https://redirect.github.com/remix-run/react-router/pull/9589">#9589</a>, <a href="https://redirect.github.com/remix-run/react-router/pull/9647">#9647</a>)</li>
<li>Properly serialize/deserialize <code>ErrorResponse</code> instances when using built-in hydration (<a href="https://redirect.github.com/remix-run/react-router/pull/9593">#9593</a>)</li>
<li>Support <code>basename</code> in static data routers (<a href="https://redirect.github.com/remix-run/react-router/pull/9591">#9591</a>)</li>
<li>Updated dependencies:
<ul>
<li><code>@remix-run/router@1.0.4</code></li>
<li><code>react-router@6.4.4</code></li>
</ul>
</li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/remix-run/react-router/compare/react-router-dom@6.4.3...react-router-dom@6.4.4">https://github.com/remix-run/react-router/compare/react-router-dom@6.4.3...react-router-dom@6.4.4</a></p>
<h2>react-router-dom@6.4.0-pre.15</h2>
<h3>Patch Changes</h3>
<ul>
<li>
<p>fix: remove internal router singleton (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9227">#9227</a>)</p>
<p>This change removes the internal module-level <code>routerSingleton</code> we create and maintain inside our data routers since it was causing a number of headaches for non-simple use cases:</p>
<ul>
<li>Unit tests are a pain because you need to find a way to reset the singleton in-between tests
<ul>
<li>Use use a <code>_resetModuleScope</code> singleton for our tests</li>
<li>...but this isn't exposed to users who may want to do their own tests around our router</li>
</ul>
</li>
<li>The JSX children <code><Route></code> objects cause non-intuitive behavior based on idiomatic react expectations
<ul>
<li>Conditional runtime <code><Route></code>'s won't get picked up</li>
<li>Adding new <code><Route></code>'s during local dev won't get picked up during HMR</li>
<li>Using external state in your elements doesn't work as one might expect (see <a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9225">#9225</a>)</li>
</ul>
</li>
</ul>
<p>Instead, we are going to lift the singleton out into user-land, so that they create the router singleton and manage it outside the react tree - which is what react 18 is encouraging with <code>useSyncExternalStore</code> anyways! This also means that since users create the router - there's no longer any difference in the rendering aspect for memory/browser/hash routers (which only impacts router/history creation) - so we can get rid of those and trim to a simple <code>RouterProvider</code></p>
<pre lang="jsx"><code>// Before
function App() {
<DataBrowserRouter>
<Route path="/" element={<Layout />}>
<Route index element={<Home />}>
</Route>
<DataBrowserRouter>
}
<p>// After<br />
let router = createBrowserRouter([{<br />
path: "/",<br />
</code></pre></p>
</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/remix-run/react-router/blob/main/packages/react-router-dom/CHANGELOG.md">react-router-dom's changelog</a>.</em></p>
<blockquote>
<h2>7.5.2</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies:
<ul>
<li><code>react-router@7.5.2</code></li>
</ul>
</li>
</ul>
<h2>7.5.1</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies:
<ul>
<li><code>react-router@7.5.1</code></li>
</ul>
</li>
</ul>
<h2>7.5.0</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies:
<ul>
<li><code>react-router@7.5.0</code></li>
</ul>
</li>
</ul>
<h2>7.4.1</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies:
<ul>
<li><code>react-router@7.4.1</code></li>
</ul>
</li>
</ul>
<h2>7.4.0</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies:
<ul>
<li><code>react-router@7.4.0</code></li>
</ul>
</li>
</ul>
<h2>7.3.0</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies:
<ul>
<li><code>react-router@7.3.0</code></li>
</ul>
</li>
</ul>
<h2>7.2.0</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies:
<ul>
<li><code>react-router@7.2.0</code></li>
</ul>
</li>
</ul>
<h2>7.1.5</h2>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/remix-run/react-router/commit/5819e0c45df69a0b4ac582497e5adb1c089385b5"><code>5819e0c</code></a> chore: Update version for release (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/13456">#13456</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/d0cac3395f004424e6afd17248d6ff166ecb6fa6"><code>d0cac33</code></a> chore: Update version for release (pre) (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/13454">#13454</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/5dd7c1580f2d782bded3f906a66d57005b083db9"><code>5dd7c15</code></a> chore: Update version for release (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/13422">#13422</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/6ce4a79774f6f9734b7457463768bc2860398263"><code>6ce4a79</code></a> chore: Update version for release (pre) (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/13412">#13412</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/15e0a5ed5cead6bd5125ea3c388d5eee9916a6bd"><code>15e0a5e</code></a> chore: Update version for release (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/13366">#13366</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/e6630c67d85e34737f6459e6c4e532e58c003dd5"><code>e6630c6</code></a> chore: Update version for release (pre) (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/13355">#13355</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/3aea1f2dd48f3922908feac6ffb82682a5648cf3"><code>3aea1f2</code></a> chore: Update version for release (pre) (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/13345">#13345</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/7350eef4e937e910308bcedd8254a4bba53058a6"><code>7350eef</code></a> chore: Update version for release (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/13322">#13322</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/9693bf442550cb1c1bf3c1a7582fb9456c68066d"><code>9693bf4</code></a> chore: Update version for release (pre) (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/13312">#13312</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/44472360ec9ea045008f453280bb749cb58e90ea"><code>4447236</code></a> Remove underscore from docs that keeps getting auto-formatted</li>
<li>Additional commits viewable in <a href="https://github.com/remix-run/react-router/commits/react-router-dom@7.5.2/packages/react-router-dom">compare view</a></li>
</ul>
</details>
<br />
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/pinot/network/alerts).
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Bump react-router and react-router-dom in /pinot-controller/src/main/resources [pinot]
Posted by "dependabot[bot] (via GitHub)" <gi...@apache.org>.
dependabot[bot] closed pull request #15635: Bump react-router and react-router-dom in /pinot-controller/src/main/resources
URL: https://github.com/apache/pinot/pull/15635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Bump react-router and react-router-dom in /pinot-controller/src/main/resources [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on PR #15635:
URL: https://github.com/apache/pinot/pull/15635#issuecomment-3947570838
@dependabot recreate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Bump react-router and react-router-dom in /pinot-controller/src/main/resources [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #15635:
URL: https://github.com/apache/pinot/pull/15635#issuecomment-2828461685
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15635?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 55.66%. Comparing base [(`f817af2`)](https://app.codecov.io/gh/apache/pinot/commit/f817af2bf66b4c686d7f0bb7626898b5070756c3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`1792cf1`)](https://app.codecov.io/gh/apache/pinot/commit/1792cf19f01f9b3d39aa7c0aa659c8d71371e706?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 4 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (f817af2) and HEAD (1792cf1). Click for more details.
>
> <details><summary>HEAD has 67 uploads less than BASE</summary>
>
>| Flag | BASE (f817af2) | HEAD (1792cf1) |
>|------|------|------|
>|unittests|6|1|
>|unittests1|3|1|
>|java-21|10|1|
>|skip-bytebuffers-false|8|1|
>|temurin|15|1|
>|skip-bytebuffers-true|4|0|
>|unittests2|3|0|
>|java-11|5|0|
>|integration|9|0|
>|integration2|3|0|
>|integration1|3|0|
>|custom-integration1|3|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #15635 +/- ##
============================================
- Coverage 62.76% 55.66% -7.10%
+ Complexity 1382 682 -700
============================================
Files 2864 2238 -626
Lines 162798 121099 -41699
Branches 24915 19325 -5590
============================================
- Hits 102180 67411 -34769
+ Misses 52910 48143 -4767
+ Partials 7708 5545 -2163
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/15635/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/15635/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/15635/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/15635/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/15635/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/15635/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/15635/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.66% <ø> (-7.07%)` | :arrow_down: |
| [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/15635/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.66% <ø> (-7.10%)` | :arrow_down: |
| [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/15635/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/15635/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.66% <ø> (-7.10%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/15635/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.66% <ø> (-7.10%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/15635/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.66% <ø> (-0.05%)` | :arrow_down: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/15635/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/15635?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Bump react-router and react-router-dom in /pinot-controller/src/main/resources [pinot]
Posted by "dependabot[bot] (via GitHub)" <gi...@apache.org>.
dependabot[bot] commented on PR #15635:
URL: https://github.com/apache/pinot/pull/15635#issuecomment-3947574835
Looks like these dependencies are up-to-date now, so this is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org