You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "chenkovsky (via GitHub)" <gi...@apache.org> on 2025/09/19 16:34:16 UTC

[PR] fix: array_reverse with null [datafusion]

chenkovsky opened a new pull request, #17673:
URL: https://github.com/apache/datafusion/pull/17673

   ## Which issue does this PR close?
   
   ```
   statement ok
   CREATE TABLE test_reverse_fixed_size AS VALUES
     (arrow_cast([1, 2, 3], 'FixedSizeList(3, Int64)')),
     (arrow_cast([4, 5, 6], 'FixedSizeList(3, Int64)')),
     (arrow_cast([NULL, 8, 9], 'FixedSizeList(3, Int64)')),
     (NULL);
   
   query ?
   SELECT array_sort(reverse(column1)) FROM test_reverse_fixed_size;
   ----
   [3, 2, 1]
   [6, 5, 4]
   [9, 8, NULL]
   NULL
   ```
   Invalid argument error: Incorrect length of null buffer for FixedSizeListArray, expected 3 got 4
   
   ## Rationale for this change
   
   null padding for fixed size list is incorrect in array_reverse.
   
   ## What changes are included in this PR?
   
   update null padding.
   
   ## Are these changes tested?
   
   UT
   
   ## Are there any user-facing changes?
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] fix: null padding for `array_reverse` on `FixedSizeList` [datafusion]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey merged PR #17673:
URL: https://github.com/apache/datafusion/pull/17673


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] fix: array_reverse with null [datafusion]

Posted by "chenkovsky (via GitHub)" <gi...@apache.org>.
chenkovsky commented on PR #17673:
URL: https://github.com/apache/datafusion/pull/17673#issuecomment-3314265383

   > Looks like this isn't quite ready for review:
   > 
   > ```
   > 
   > 1. query failed: DataFusion error: type_coercion
   > caused by
   > Error during planning: Cannot automatically convert FixedSizeList(Field { name: "item", data_type: Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }, 3) to Utf8
   > [SQL] SELECT reverse(column1) FROM test_reverse_fixed_size;
   > at /Users/runner/work/datafusion/datafusion/datafusion/sqllogictest/test_files/array.slt:8012
   > ```
   
   sorry for typo 😄


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] fix: array_reverse with null [datafusion]

Posted by "Omega359 (via GitHub)" <gi...@apache.org>.
Omega359 commented on PR #17673:
URL: https://github.com/apache/datafusion/pull/17673#issuecomment-3313589727

   Looks like this isn't quite ready for review:
   
   ```
   
   1. query failed: DataFusion error: type_coercion
   caused by
   Error during planning: Cannot automatically convert FixedSizeList(Field { name: "item", data_type: Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }, 3) to Utf8
   [SQL] SELECT reverse(column1) FROM test_reverse_fixed_size;
   at /Users/runner/work/datafusion/datafusion/datafusion/sqllogictest/test_files/array.slt:8012
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org