You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "khanimteyaz (GitHub)" <gi...@apache.org> on 2019/01/02 07:06:52 UTC

[GitHub] [incubator-dubbo] khanimteyaz commented on issue #3095: remove @Async from core framework.

> By the way, the implementation of the async feature has been an enhncent or patch effort based on the legacy code. I think it definitely deserves an refactor.
> For example, you can find that we have three types of Result, they are`AsyncRpcResult`, `RpcResult`, `SimpleAsyncRpcResult`.
> 
> * `RpcResult` are for sync call
> * `AsyncRpcResult` and `SimpleAsyncRpcResult` are for different types of async calls
> * `AsyncRpcResult` inside composes two futures.
>   But I think we should unify them to one RpcResult, which should be an instance of `CompletationStage`.
> 
> Given that hou have put forward many constructive suggestions recently, which are of great help to us. It would be great if you've got some experience or you'd like to take a look at this part.

@chickenlj Thanks for your detail information. I will try my best to suggest something which if there is something good I can comeup. Thanks for your appreciation. 
For the same I have created an issue [3113](https://github.com/apache/incubator-dubbo/issues/3113)

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3095 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org