You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by GitBox <gi...@apache.org> on 2020/05/30 09:00:42 UTC
[GitHub] [ofbiz-framework] priyasharma1 commented on a change in pull request #166: Fixed: Create Payment service throws an exception when receiving payment on order (OFBIZ-11754)
priyasharma1 commented on a change in pull request #166:
URL: https://github.com/apache/ofbiz-framework/pull/166#discussion_r432824737
##########
File path: applications/content/groovyScripts/content/ContentServices.groovy
##########
@@ -115,7 +113,7 @@ def createContentAlternativeUrl() {
dataResourceId = serviceResult.dataResourceId
}
} catch (GenericServiceException e) {
- Debug.logInfo(e, MODULE)
Review comment:
Thanks @verma-pawan
I have the changes as per your suggestion.
Earlier, since the original XML service used break-on-error="false" without any logs at all, so I could not decide whether to log error or info.
So thank you for your inputs in clearing up my doubt.
##########
File path: applications/content/groovyScripts/content/ContentServices.groovy
##########
@@ -115,7 +113,7 @@ def createContentAlternativeUrl() {
dataResourceId = serviceResult.dataResourceId
}
} catch (GenericServiceException e) {
- Debug.logInfo(e, MODULE)
Review comment:
Thanks @verma-pawan
I have made the changes as per your suggestion.
Earlier, since the original XML service used break-on-error="false" without any logs at all, so I could not decide whether to log error or info.
So thank you for your inputs in clearing up my doubt.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org