[GitHub] [zookeeper] maoling commented on issue #1079: ZOOKEEPER-3231:Purge task may lost data when the recent snapshots are all invalid

[GitBox <gi...@apache.org>]

maoling commented on issue #1079: ZOOKEEPER-3231:Purge task may lost data when the recent snapshots are all invalid
URL: https://github.com/apache/zookeeper/pull/1079#issuecomment-533952451
 
 
   @anmolnar
   > Have you considered @enixon 's suggestion about removing invalid snapshot files to reclaim more disk space?
   
   - Since these invalid snapshots are all recent, if we remove them arbitrary, users will observe this easily, mistake we lose snapshots data, that will be very embarrassing. maybe renaming it to something like this:`invalid-snapshot.fa3200000013` is better?
   - On the other hand, these invalid snapshots are no need of special treatment.Because in the next round purge task, it will be deleted as normally. so it's not a problem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services