You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2016/06/16 16:14:23 UTC

svn commit: r1748754 - /pdfbox/branches/2.0/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature.java

Author: tilman
Date: Thu Jun 16 16:14:23 2016
New Revision: 1748754

URL: http://svn.apache.org/viewvc?rev=1748754&view=rev
Log:
PDFBOX-3017: assign name/location/reason the values set in visibleSignatureProperties; don't use signatureOptions.setVisualSignature(visibleSignatureProperties) as this is misleading

Modified:
    pdfbox/branches/2.0/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature.java

Modified: pdfbox/branches/2.0/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature.java?rev=1748754&r1=1748753&r2=1748754&view=diff
==============================================================================
--- pdfbox/branches/2.0/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature.java (original)
+++ pdfbox/branches/2.0/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature.java Thu Jun 16 16:14:23 2016
@@ -133,12 +133,19 @@ public class CreateVisibleSignature exte
 
         // create signature dictionary
         PDSignature signature = new PDSignature();
-        signature.setFilter(PDSignature.FILTER_ADOBE_PPKLITE); // default filter
+
+        // default filter
+        signature.setFilter(PDSignature.FILTER_ADOBE_PPKLITE);
+        
         // subfilter for basic and PAdES Part 2 signatures
         signature.setSubFilter(PDSignature.SUBFILTER_ADBE_PKCS7_DETACHED);
-        signature.setName("signer name");
-        signature.setLocation("signer location");
-        signature.setReason("reason for signature");
+        
+        if (visibleSignatureProperties != null)
+        {
+            signature.setName(visibleSignatureProperties.getSignerName());
+            signature.setLocation(visibleSignatureProperties.getSignerLocation());
+            signature.setReason(visibleSignatureProperties.getSignatureReason());
+        }
 
         // the signing date, needed for valid signature
         signature.setSignDate(Calendar.getInstance());
@@ -147,7 +154,7 @@ public class CreateVisibleSignature exte
         if (visibleSignatureProperties != null && visibleSignatureProperties.isVisualSignEnabled())
         {
             signatureOptions = new SignatureOptions();
-            signatureOptions.setVisualSignature(visibleSignatureProperties);
+            signatureOptions.setVisualSignature(visibleSignatureProperties.getVisibleSignature());
             signatureOptions.setPage(visibleSignatureProperties.getPage() - 1);
             doc.addSignature(signature, this, signatureOptions);
         }