You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/04/14 13:15:19 UTC
[GitHub] [accumulo] milleruntime opened a new pull request #2018: Create new ZKDroppingTServer
milleruntime opened a new pull request #2018:
URL: https://github.com/apache/accumulo/pull/2018
Putting this class here because it extends TServer and the constructor is package private. Required to run
https://github.com/apache/accumulo-testing/pull/139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2018: Create new ZKDroppingTServer
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2018:
URL: https://github.com/apache/accumulo/pull/2018#issuecomment-819570739
> FWIW I'm working on a test right now that extends TServer. I opted to add the `protected` modifier to the constructor and placed the class in the test package.
OK cool. I wasn't sure if it was appropriate it or not. But it looks like being able to extend it for testing is very useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime closed pull request #2018: Create new ZKDroppingTServer
Posted by GitBox <gi...@apache.org>.
milleruntime closed pull request #2018:
URL: https://github.com/apache/accumulo/pull/2018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on pull request #2018: Create new ZKDroppingTServer
Posted by GitBox <gi...@apache.org>.
dlmarion commented on pull request #2018:
URL: https://github.com/apache/accumulo/pull/2018#issuecomment-819545532
FWIW I'm working on a test right now that extends TServer. I opted to add the `protected` modifier to the constructor and placed the class in the test package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2018: Create new ZKDroppingTServer
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2018:
URL: https://github.com/apache/accumulo/pull/2018#issuecomment-819584487
I will close this since it seems making the constructor protected is a better move.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org