You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "uranusjr (via GitHub)" <gi...@apache.org> on 2023/02/20 09:57:07 UTC

[GitHub] [airflow] uranusjr opened a new pull request, #29631: Avoid unneeded Connexion constructs

uranusjr opened a new pull request, #29631:
URL: https://github.com/apache/airflow/pull/29631

   We only use Connexion's App class to create a Flask Blueprint, so really we can go one level lower and use the FlaskApi interface directly instead.
   
   Connexion's spec-loading also supports dynamic spec templating via Jinja2, but we don't and CAN'T use it (won't work for any of the OpenAPI clients), so it can be entirely skipped by passing in a pre-loaded dict (instead of a path to the YAML file). Jinja2 templating is not cheap!
   
   The above provides a ~5% save in webserver startup on my machine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] uranusjr commented on pull request #29631: Avoid unneeded Connexion constructs

Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #29631:
URL: https://github.com/apache/airflow/pull/29631#issuecomment-1437416544

   `ImportError: cannot import name 'enums' from 'google.cloud.bigtable_admin_v2'`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] uranusjr merged pull request #29631: Avoid unneeded Connexion constructs

Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr merged PR #29631:
URL: https://github.com/apache/airflow/pull/29631


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org