[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2439: Fixed MMC starting frequency

[GitBox <gi...@apache.org>]

apache-mynewt-bot commented on pull request #2439:
URL: https://github.com/apache/mynewt-core/pull/2439#issuecomment-745034925


   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### hw/drivers/mmc/src/mmc.c
   <details>
   
   ```diff
   @@ -67,20 +67,20 @@
    
    static struct hal_spi_settings mmc_settings = {
        .data_order = HAL_SPI_MSB_FIRST,
   -    .data_mode  = HAL_SPI_MODE0,
   +    .data_mode = HAL_SPI_MODE0,
        /* XXX: MMC initialization accepts clocks in the range 100-400KHz */
        /* TODO: switch to high-speed aka 25MHz after initialization. */
        /* Currently the lowest clock acceptable is 125KHz */
   -    .baudrate   = 125,
   -    .word_size  = HAL_SPI_WORD_SIZE_8BIT,
   +    .baudrate = 125,
   +    .word_size = HAL_SPI_WORD_SIZE_8BIT,
    };
    
    /* FIXME: currently limited to single MMC spi device */
    static struct mmc_cfg {
   -    int                      spi_num;
   -    int                      ss_pin;
   -    void                     *spi_cfg;
   -    struct hal_spi_settings  *settings;
   +    int spi_num;
   +    int ss_pin;
   +    void *spi_cfg;
   +    struct hal_spi_settings *settings;
    } g_mmc_cfg;
    
    static int
   ```
   
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org