You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by "juergbi (via GitHub)" <gi...@apache.org> on 2025/11/14 09:05:23 UTC

[PR] Artifact cache fixes [buildstream]

juergbi opened a new pull request, #2091:
URL: https://github.com/apache/buildstream/pull/2091

   *   _artifactcache.py: Fix presence checks of protobuf digest fields
       
       Python truth values can't be used for presence checks of embedded protobuf message fields. Use `HasField()` instead. This prevents passing invalid digests to the Remote Asset server.
       
       Fixes #2090.
   
   *   _artifactcache.py: Add `public_data` to list of referenced blobs
   
   *    _artifactcache.py: Push and fetch sources
       The source digest is already stored in the artifact proto and added to the list of referenced directories if the buildtree is cached, however, the actual push and fetch was missing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Artifact cache fixes [buildstream]

Posted by "jerenkrantz (via GitHub)" <gi...@apache.org>.
jerenkrantz commented on PR #2091:
URL: https://github.com/apache/buildstream/pull/2091#issuecomment-3533403194

   I have tested this PR locally and artifact pushes passes the `buildgrid-asset` validator checks and are able to be successfully served.  (I checked both the periodic validation and the per-request validation upon expired/empty validation and both passed.)
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Artifact cache fixes [buildstream]

Posted by "juergbi (via GitHub)" <gi...@apache.org>.
juergbi merged PR #2091:
URL: https://github.com/apache/buildstream/pull/2091


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org