You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/13 13:41:59 UTC
[GitHub] [spark] tenglei opened a new pull request #34582: [SPARK-37289][SQL] Remove the unnecessary function
tenglei opened a new pull request #34582:
URL: https://github.com/apache/spark/pull/34582
What changes were proposed in this pull request?
This PR remove the unnecessary function called partitionSchemaOption in HadoopFsRelation.scala.
Why are the changes needed?
The partitionSchemaOption is unnecessary in HadoopFsRelation, it will make more complicated logical in HadoopFsRelation,which we can simply use partitionSchema.isEmpty or partitionSchema.nonEmpty instead
Does this PR introduce any user-facing change?
No,only change the expression.
How was this patch tested?
Pass existed tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wzhfy commented on pull request #34582: [SPARK-37289][SQL] Remove the unnecessary function
Posted by GitBox <gi...@apache.org>.
wzhfy commented on pull request #34582:
URL: https://github.com/apache/spark/pull/34582#issuecomment-968098317
@tenglei please make the title more specific by pointing out the function name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34582: [SPARK-37289][SQL] Remove the unnecessary function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34582:
URL: https://github.com/apache/spark/pull/34582#issuecomment-968075325
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wzhfy commented on pull request #34582: [SPARK-37289][SQL] Remove the unnecessary function
Posted by GitBox <gi...@apache.org>.
wzhfy commented on pull request #34582:
URL: https://github.com/apache/spark/pull/34582#issuecomment-968098112
jenkins, test this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #34582: [SPARK-37289][SQL] Remove `partitionSchemaOption` function
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #34582:
URL: https://github.com/apache/spark/pull/34582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34582: [SPARK-37289][SQL] Remove the unnecessary function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34582:
URL: https://github.com/apache/spark/pull/34582#issuecomment-968103358
**[Test build #145191 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145191/testReport)** for PR 34582 at commit [`f96eb3a`](https://github.com/apache/spark/commit/f96eb3a85a2ff40fa35e18f2ae6cbba2da861e17).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34582: [SPARK-37289][SQL] Remove the unnecessary function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34582:
URL: https://github.com/apache/spark/pull/34582#issuecomment-968118706
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49660/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34582: [SPARK-37289][SQL] Remove the unnecessary function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34582:
URL: https://github.com/apache/spark/pull/34582#issuecomment-968156144
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145191/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34582: [SPARK-37289][SQL] Remove the unnecessary function
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34582:
URL: https://github.com/apache/spark/pull/34582#issuecomment-968103358
**[Test build #145191 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145191/testReport)** for PR 34582 at commit [`f96eb3a`](https://github.com/apache/spark/commit/f96eb3a85a2ff40fa35e18f2ae6cbba2da861e17).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34582: [SPARK-37289][SQL] Remove the unnecessary function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34582:
URL: https://github.com/apache/spark/pull/34582#issuecomment-968257769
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34582: [SPARK-37289][SQL] Remove `partitionSchemaOption` function
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34582:
URL: https://github.com/apache/spark/pull/34582#issuecomment-968361020
@tenglei . I added you to the Apache Spark contributor group and assigned SPARK-37289 to you.
Welcome to the Apache Spark community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34582: [SPARK-37289][SQL] Remove the unnecessary function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34582:
URL: https://github.com/apache/spark/pull/34582#issuecomment-968075325
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34582: [SPARK-37289][SQL] Remove the unnecessary function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34582:
URL: https://github.com/apache/spark/pull/34582#issuecomment-968109749
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49660/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34582: [SPARK-37289][SQL] Remove the unnecessary function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34582:
URL: https://github.com/apache/spark/pull/34582#issuecomment-968121095
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49660/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34582: [SPARK-37289][SQL] Remove the unnecessary function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34582:
URL: https://github.com/apache/spark/pull/34582#issuecomment-968151893
**[Test build #145191 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145191/testReport)** for PR 34582 at commit [`f96eb3a`](https://github.com/apache/spark/commit/f96eb3a85a2ff40fa35e18f2ae6cbba2da861e17).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34582: [SPARK-37289][SQL] Remove the unnecessary function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34582:
URL: https://github.com/apache/spark/pull/34582#issuecomment-968156144
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145191/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34582: [SPARK-37289][SQL] Remove the unnecessary function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34582:
URL: https://github.com/apache/spark/pull/34582#issuecomment-968121095
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49660/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tenglei commented on pull request #34582: [SPARK-37289][SQL] Remove `partitionSchemaOption` function
Posted by GitBox <gi...@apache.org>.
tenglei commented on pull request #34582:
URL: https://github.com/apache/spark/pull/34582#issuecomment-968465580
> @tenglei . I added you to the Apache Spark contributor group and assigned [SPARK-37289](https://issues.apache.org/jira/browse/SPARK-37289) to you. Welcome to the Apache Spark community.
Thanks for the assist, appreciate your time. I'm very happy to join the Spark community~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org