[GitHub] [spark] HyukjinKwon commented on a change in pull request #28392: [SPARK-31594][SQL] Do not display rand/randn seed numbers in schema

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #28392:
URL: https://github.com/apache/spark/pull/28392#discussion_r416580510



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala
##########
@@ -102,6 +102,8 @@ case class Rand(child: Expression) extends RDG with ExpressionWithRandomSeed {
   }
 
   override def freshCopy(): Rand = Rand(child)
+
+  override def sql: String = "rand()"

Review comment:
       Hmmm .. shouldn't we print out the seed when it's explicitly given?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org