You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/26 17:48:01 UTC
[GitHub] [beam] damccorm opened a new pull request, #22917: Add clear function for bag state types
damccorm opened a new pull request, #22917:
URL: https://github.com/apache/beam/pull/22917
This allows all the bag type states to clear their state and adds tests/integration tests for them.
Part of #22736
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #22917: Add clear function for bag state types
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #22917:
URL: https://github.com/apache/beam/pull/22917#issuecomment-1228762737
Run Go PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #22917: Add clear function for bag state types
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #22917:
URL: https://github.com/apache/beam/pull/22917#issuecomment-1228833542
Go Run PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on a diff in pull request #22917: Add clear function for bag state types
Posted by GitBox <gi...@apache.org>.
riteshghorse commented on code in PR #22917:
URL: https://github.com/apache/beam/pull/22917#discussion_r957443698
##########
sdks/go/test/integration/integration.go:
##########
@@ -27,7 +27,8 @@
// Running integration tests can be done with a go test call with any flags that
// are required by the test pipelines, such as --runner or --endpoint.
// Example:
-// go test -v ./sdks/go/test/integration/... --runner=portable --endpoint=localhost:8099
+//
Review Comment:
oh okay then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22917: Add clear function for bag state types
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22917:
URL: https://github.com/apache/beam/pull/22917#issuecomment-1229004555
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on a diff in pull request #22917: Add clear function for bag state types
Posted by GitBox <gi...@apache.org>.
riteshghorse commented on code in PR #22917:
URL: https://github.com/apache/beam/pull/22917#discussion_r957432372
##########
sdks/go/test/integration/integration.go:
##########
@@ -27,7 +27,8 @@
// Running integration tests can be done with a go test call with any flags that
// are required by the test pipelines, such as --runner or --endpoint.
// Example:
-// go test -v ./sdks/go/test/integration/... --runner=portable --endpoint=localhost:8099
+//
Review Comment:
```suggestion
```
rm spare line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #22917: Add clear function for bag state types
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #22917:
URL: https://github.com/apache/beam/pull/22917#issuecomment-1228882194
Run Go Postcommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #22917: Add clear function for bag state types
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #22917:
URL: https://github.com/apache/beam/pull/22917#issuecomment-1229003986
R: @riteshghorse
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on a diff in pull request #22917: Add clear function for bag state types
Posted by GitBox <gi...@apache.org>.
riteshghorse commented on code in PR #22917:
URL: https://github.com/apache/beam/pull/22917#discussion_r957432372
##########
sdks/go/test/integration/integration.go:
##########
@@ -27,7 +27,8 @@
// Running integration tests can be done with a go test call with any flags that
// are required by the test pipelines, such as --runner or --endpoint.
// Example:
-// go test -v ./sdks/go/test/integration/... --runner=portable --endpoint=localhost:8099
+//
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #22917: Add clear function for bag state types
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #22917:
URL: https://github.com/apache/beam/pull/22917#discussion_r957439552
##########
sdks/go/test/integration/integration.go:
##########
@@ -27,7 +27,8 @@
// Running integration tests can be done with a go test call with any flags that
// are required by the test pipelines, such as --runner or --endpoint.
// Example:
-// go test -v ./sdks/go/test/integration/... --runner=portable --endpoint=localhost:8099
+//
Review Comment:
Interestingly, `go fmt` added this line, so I'm actually inclined to leave it. It is kinda odd though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #22917: Add clear function for bag state types
Posted by GitBox <gi...@apache.org>.
damccorm merged PR #22917:
URL: https://github.com/apache/beam/pull/22917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #22917: Add clear function for bag state types
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22917:
URL: https://github.com/apache/beam/pull/22917#issuecomment-1228766079
# [Codecov](https://codecov.io/gh/apache/beam/pull/22917?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22917](https://codecov.io/gh/apache/beam/pull/22917?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70c7419) into [master](https://codecov.io/gh/apache/beam/commit/172bd31d01bcc1e87a5aa1e37379a669c81b46bf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (172bd31) will **decrease** coverage by `0.00%`.
> The diff coverage is `40.54%`.
```diff
@@ Coverage Diff @@
## master #22917 +/- ##
==========================================
- Coverage 73.90% 73.89% -0.01%
==========================================
Files 713 713
Lines 94464 94497 +33
==========================================
+ Hits 69809 69824 +15
- Misses 23358 23376 +18
Partials 1297 1297
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `51.35% <40.54%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/22917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/go/pkg/beam/core/runtime/exec/userstate.go](https://codecov.io/gh/apache/beam/pull/22917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZXhlYy91c2Vyc3RhdGUuZ28=) | `10.05% <0.00%> (-1.00%)` | :arrow_down: |
| [sdks/go/pkg/beam/core/state/state.go](https://codecov.io/gh/apache/beam/pull/22917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3N0YXRlL3N0YXRlLmdv) | `76.96% <100.00%> (+1.96%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org