[jira] [Commented] (MINIFICPP-695) NanoFi Examples appear to be broken

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINIFICPP-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717314#comment-16717314 ] 

ASF GitHub Bot commented on MINIFICPP-695:
------------------------------------------

GitHub user arpadboda opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/459

    MINIFICPP-695 - NanoFi Examples appear to be broken

    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] If applicable, have you updated the LICENSE file?
    - [ ] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/arpadboda/nifi-minifi-cpp MINIFICPP-695

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/459.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #459
    
----
commit f8d01f20a77857fc4fae0ebfca0bada22cc20963
Author: Arpad Boda <ab...@...>
Date:   2018-12-11T14:54:31Z

    MINIFICPP-695 - NanoFi Examples appear to be broken

----


> NanoFi Examples appear to be broken
> -----------------------------------
>
>                 Key: MINIFICPP-695
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-695
>             Project: NiFi MiNiFi C++
>          Issue Type: Bug
>            Reporter: Mr TheSegfault
>            Assignee: Arpad Boda
>            Priority: Blocker
>              Labels: nanofi
>
> When testing recent changes the examples appear to not work due to a mis-configuration of the client. Not sure when/what broke it specifically, but we should ensure that examples function. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)