You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2018/06/19 22:32:17 UTC
[Impala-ASF-CR] Update Impala to adapt to KRPC changes
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10767
Change subject: Update Impala to adapt to KRPC changes
......................................................................
Update Impala to adapt to KRPC changes
RecordHandlingStarted() now takes a raw pointer.
Required another include.
TODO: This could be squashed with the other KRPC changes.
Change-Id: I5424b54fbb6ab727c9daeaeea3032384fe6c53be
---
M be/src/rpc/impala-service-pool.cc
M be/src/runtime/krpc-data-stream-mgr.cc
2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/10767/2
--
To view, visit http://gerrit.cloudera.org:8080/10767
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5424b54fbb6ab727c9daeaeea3032384fe6c53be
Gerrit-Change-Number: 10767
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] Update Impala to adapt to KRPC changes
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/10767 )
Change subject: Update Impala to adapt to KRPC changes
......................................................................
Update Impala to adapt to KRPC changes
RecordHandlingStarted() now takes a raw pointer.
Required another include.
TODO: This could be squashed with the other KRPC changes.
Change-Id: I5424b54fbb6ab727c9daeaeea3032384fe6c53be
---
M be/src/rpc/impala-service-pool.cc
M be/src/runtime/krpc-data-stream-mgr.cc
2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/10767/4
--
To view, visit http://gerrit.cloudera.org:8080/10767
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5424b54fbb6ab727c9daeaeea3032384fe6c53be
Gerrit-Change-Number: 10767
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] Update Impala to adapt to KRPC changes
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has abandoned this change. ( http://gerrit.cloudera.org:8080/10767 )
Change subject: Update Impala to adapt to KRPC changes
......................................................................
Abandoned
Not needed anymore.
--
To view, visit http://gerrit.cloudera.org:8080/10767
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I5424b54fbb6ab727c9daeaeea3032384fe6c53be
Gerrit-Change-Number: 10767
Gerrit-PatchSet: 5
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] Update Impala to adapt to KRPC changes
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10767 )
Change subject: Update Impala to adapt to KRPC changes
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10767/2/be/src/rpc/impala-service-pool.cc
File be/src/rpc/impala-service-pool.cc:
http://gerrit.cloudera.org:8080/#/c/10767/2/be/src/rpc/impala-service-pool.cc@223
PS2, Line 223: incoming->RecordHandlingStarted(incoming_queue_time_.get());
This API changed.
http://gerrit.cloudera.org:8080/#/c/10767/2/be/src/runtime/krpc-data-stream-mgr.cc
File be/src/runtime/krpc-data-stream-mgr.cc:
http://gerrit.cloudera.org:8080/#/c/10767/2/be/src/runtime/krpc-data-stream-mgr.cc@26
PS2, Line 26: #include "kudu/util/net/sockaddr.h"
After some cleanup on KRPC's side this include became necessary.
--
To view, visit http://gerrit.cloudera.org:8080/10767
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5424b54fbb6ab727c9daeaeea3032384fe6c53be
Gerrit-Change-Number: 10767
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jun 2018 00:55:06 +0000
Gerrit-HasComments: Yes