[jira] [Commented] (KAFKA-5540) Deprecate and remove internal converter configs

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-5540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070165#comment-17070165 ] 

ASF GitHub Bot commented on KAFKA-5540:
---------------------------------------

kkonstantine commented on pull request #4467: KAFKA-5540 : Deprecate and remove internal converter configs
URL: https://github.com/apache/kafka/pull/4467
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Deprecate and remove internal converter configs
> -----------------------------------------------
>
>                 Key: KAFKA-5540
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5540
>             Project: Kafka
>          Issue Type: Bug
>          Components: KafkaConnect
>    Affects Versions: 0.11.0.0
>            Reporter: Ewen Cheslack-Postava
>            Assignee: Chris Egerton
>            Priority: Major
>              Labels: needs-kip
>             Fix For: 2.0.0
>
>
> The internal.key.converter and internal.value.converter were original exposed as configs because a) they are actually pluggable and b) providing a default would require relying on the JsonConverter always being available, which until we had classloader isolation it was possible might be removed for compatibility reasons.
> However, this has ultimately just caused a lot more trouble and confusion than it is worth. We should deprecate the configs, give them a default of JsonConverter (which is also kind of nice since it results in human-readable data in the internal topics), and then ultimately remove them in the next major version.
> These are all public APIs so this will need a small KIP before we can make the change.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)