You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Hisoka-X (via GitHub)" <gi...@apache.org> on 2023/07/11 06:26:35 UTC

[GitHub] [spark] Hisoka-X commented on a diff in pull request #41933: [SPARK-44370][CONNECT] Migrate Buf remote generation alpha to remote plugins

Hisoka-X commented on code in PR #41933:
URL: https://github.com/apache/spark/pull/41933#discussion_r1259244060


##########
connector/connect/common/src/main/buf.gen.yaml:
##########
@@ -16,18 +16,18 @@
 #
 version: v1
 plugins:
-  - remote: buf.build/protocolbuffers/plugins/cpp:v3.20.0-1
+  - plugin: buf.build/protocolbuffers/cpp:v21.7

Review Comment:
   I'm not sure the version should be updated to this, but this (and v3.14.0) is the most older version maintained by the Buf team. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org