You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/21 14:19:24 UTC
[GitHub] [skywalking-satellite] wangrzneu opened a new pull request #39: set MAXPROCS according to real cpu quota
wangrzneu opened a new pull request #39:
URL: https://github.com/apache/skywalking-satellite/pull/39
GOMAXPROCS needs to be set according to real CPU quota especially in container environment with CPU limit, but runtime.NumCPU() will return the CPU number of machine, which may be very large and will affect the performance. "go.uber.org/automaxprocs" can set the GOMAXPROCS according to the environment automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #39: set MAXPROCS according to real cpu quota
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #39:
URL: https://github.com/apache/skywalking-satellite/pull/39#discussion_r617926184
##########
File path: go.mod
##########
@@ -14,6 +14,7 @@ require (
github.com/sirupsen/logrus v1.7.0
github.com/spf13/viper v1.7.1
github.com/urfave/cli/v2 v2.3.0
+ go.uber.org/automaxprocs v1.4.0
Review comment:
As this is a new runtime dependency, we need you to update the LICENSE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng merged pull request #39: set MAXPROCS according to real cpu quota
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #39:
URL: https://github.com/apache/skywalking-satellite/pull/39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wangrzneu commented on a change in pull request #39: set MAXPROCS according to real cpu quota
Posted by GitBox <gi...@apache.org>.
wangrzneu commented on a change in pull request #39:
URL: https://github.com/apache/skywalking-satellite/pull/39#discussion_r618311137
##########
File path: go.mod
##########
@@ -14,6 +14,7 @@ require (
github.com/sirupsen/logrus v1.7.0
github.com/spf13/viper v1.7.1
github.com/urfave/cli/v2 v2.3.0
+ go.uber.org/automaxprocs v1.4.0
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] EvanLjp commented on pull request #39: set MAXPROCS according to real cpu quota
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on pull request #39:
URL: https://github.com/apache/skywalking-satellite/pull/39#issuecomment-824123985
let me fix the ci process, please wait for a moment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wangrzneu commented on pull request #39: set MAXPROCS according to real cpu quota
Posted by GitBox <gi...@apache.org>.
wangrzneu commented on pull request #39:
URL: https://github.com/apache/skywalking-satellite/pull/39#issuecomment-824753675
@wu-sheng Please help to review it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] gxthrj commented on pull request #39: set MAXPROCS according to real cpu quota
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #39:
URL: https://github.com/apache/skywalking-satellite/pull/39#issuecomment-824127253
> let me fix the ci process, please wait for a moment
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org