You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/16 09:26:21 UTC
[GitHub] [incubator-shardingsphere] menghaoranss opened a new issue #4778:
Optimize configuration structure of config®istry center
menghaoranss opened a new issue #4778: Optimize configuration structure of config®istry center
URL: https://github.com/apache/incubator-shardingsphere/issues/4778
For #4522
Based on the completed split of the config center and registry center, the related configuration structure will be adjusted as follows:
#### Current structure
```
/
├─orchestration-namespace
├─orchestration-name
│ ├─config
│ │ ├─authentication
│ │ ├─props
│ │ ├─schema
│ │ │ ├─sharding-schema-name
│ │ │ │ ├─datasource
│ │ │ │ └─rule
│ │ │ ├─encrypt-schema-name
│ │ │ │ ├─datasource
│ │ │ │ └─rule
│ │ │ └─master_slave-schema-name
│ │ │ │ ├─datasource
│ │ │ │ └─rule
│ ├─state
│ │ ├─datasources
│ │ └─instances
```
#### New structure
##### config center
```
/
├─orchestration-namespace
├─orchestration-name
│ ├─config
│ │ ├─authentication
│ │ ├─props
│ │ ├─schema
│ │ │ ├─sharding-schema-name
│ │ │ │ ├─datasource
│ │ │ │ ├─rule
│ │ │ │ └─type
│ │ │ ├─encrypt-schema-name
│ │ │ │ ├─datasource
│ │ │ │ ├─rule
│ │ │ │ └─type
│ │ │ └─master_slave-schema-name
│ │ │ │ ├─datasource
│ │ │ │ ├─rule
│ │ │ │ └─type
```
##### registry center
```
/
├─orchestration-namespace
├─orchestration-name
│ ├─registry
│ │ ├─states
│ │ └─instances
```
Note:
+ Add a new schema type node under schema node of config center to distinguish the current scheme configuration type (sharding / encrypt / master-slave) (previously judged according to rule content, content may be modified or optimized, which is not beneficial expansion), the type node content contains :
+ SHARDING
+ ENCRYPT
+ MASTER_SLAVE
+ SHADOW
+ Split the registry and modify state node to registry node to match the registry
+ Modify the datasources node of registry center to states, currently used to record the status of slave database
Task lists:
[ ] 1. Persist and get schema type from type node of config center
[ ] 2. Refactor persist and get configuration from registry center
[ ] 3. Refactor the judgment logic and code reference of the schema type
[ ] 4. Refactor unit tests
[ ] 5. Refactor UI
Any suggestions， please reply directly to this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4778:
Optimize configuration structure of config®istry center
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #4778: Optimize configuration structure of config®istry center
URL: https://github.com/apache/incubator-shardingsphere/issues/4778#issuecomment-599979969
It is better if change `states` to `status`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4778:
Optimize configuration structure of config®istry center
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #4778: Optimize configuration structure of config®istry center
URL: https://github.com/apache/incubator-shardingsphere/issues/4778#issuecomment-599980547
Add `rule` type maybe not good because the type can be extension by user via SPI. It is better do not add a static field here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue
#4778: Optimize configuration structure of config®istry center
Posted by GitBox <gi...@apache.org>.
terrymanu edited a comment on issue #4778: Optimize configuration structure of config®istry center
URL: https://github.com/apache/incubator-shardingsphere/issues/4778#issuecomment-599980547
Add `type` maybe not good because the type can be extension by user via SPI. It is better do not add a static field here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [shardingsphere] terrymanu closed issue #4778: Optimize configuration structure of config®istry center
Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #4778:
URL: https://github.com/apache/shardingsphere/issues/4778
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4778:
Optimize configuration structure of config®istry center
Posted by GitBox <gi...@apache.org>.
kimmking commented on issue #4778: Optimize configuration structure of config®istry center
URL: https://github.com/apache/incubator-shardingsphere/issues/4778#issuecomment-600956475
proxy -> proxies is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] menghaoranss commented on issue #4778:
Optimize configuration structure of config®istry center
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on issue #4778: Optimize configuration structure of config®istry center
URL: https://github.com/apache/incubator-shardingsphere/issues/4778#issuecomment-600487131
> It is better if change `states` to `status`
@terrymanu I have changed the `state` node to `registry` node, I understand that `registry` node stores proxy and datasource runtime info(contains instance and status) which registered to the center . so , i consider whether it better to use `proxy` instead of `instances`, just like:
```
/
├─orchestration-namespace
├─orchestration-name
│ ├─registry
│ │ ├─proxy
│ │ └─datasources
```
Do you have any good suggestions about this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] menghaoranss commented on issue #4778:
Optimize configuration structure of config®istry center
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on issue #4778: Optimize configuration structure of config®istry center
URL: https://github.com/apache/incubator-shardingsphere/issues/4778#issuecomment-599994705
> Add `type` maybe not good because the type can be extension by user via SPI. It is better do not add a static field here.
ok, I will reconsider the design of this part, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services