You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@bahir.apache.org by GitBox <gi...@apache.org> on 2020/08/30 17:51:38 UTC

[GitHub] [bahir-flink] lresende commented on a change in pull request #98: [BAHIR-245] Add git .asf.yaml file

lresende commented on a change in pull request #98:
URL: https://github.com/apache/bahir-flink/pull/98#discussion_r479797297



##########
File path: pom.xml
##########
@@ -257,6 +257,7 @@
           </executions>
           <configuration>
             <excludes>
+              <exclude>.asf.yaml</exclude>
               <exclude>.gitignore</exclude>

Review comment:
       You shouldn't exclude this.

##########
File path: .asf.yaml
##########
@@ -0,0 +1,10 @@
+github:

Review comment:
       Yaml files allow asf license header using `#` at the beginning of the line.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org