You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Guido Barosio (JIRA)" <ji...@apache.org> on 2008/09/11 18:19:50 UTC
[jira] Created: (SHINDIG-590) javascript operators correctio
javascript operators correctio
------------------------------
Key: SHINDIG-590
URL: https://issues.apache.org/jira/browse/SHINDIG-590
Project: Shindig
Issue Type: Improvement
Components: Features (Javascript)
Reporter: Guido Barosio
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-590) javascript operators correctio
Posted by "Guido Barosio (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guido Barosio updated SHINDIG-590:
----------------------------------
Attachment: javascript_operators.patch
> javascript operators correctio
> ------------------------------
>
> Key: SHINDIG-590
> URL: https://issues.apache.org/jira/browse/SHINDIG-590
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript)
> Reporter: Guido Barosio
> Attachments: javascript_operators.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-590) javascript operators correctio
Posted by "Guido Barosio (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630243#action_12630243 ]
Guido Barosio commented on SHINDIG-590:
---------------------------------------
Since we already know what we are comparing (see patch) I though about using the === operator instead of the ==
Guido Barosio
> javascript operators correctio
> ------------------------------
>
> Key: SHINDIG-590
> URL: https://issues.apache.org/jira/browse/SHINDIG-590
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript)
> Reporter: Guido Barosio
> Attachments: javascript_operators.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-590) javascript operators correctio
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630250#action_12630250 ]
Kevin Brown commented on SHINDIG-590:
-------------------------------------
=== should almost always be used in javascript, == only if you really know what you're doing.
That said, the container code doesn't really get that much attention in this project because most integrations don't use it. You don't need a x thousand line block of javascript to generate iframe urls.
> javascript operators correctio
> ------------------------------
>
> Key: SHINDIG-590
> URL: https://issues.apache.org/jira/browse/SHINDIG-590
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript)
> Reporter: Guido Barosio
> Attachments: javascript_operators.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-590) javascript operators correctio
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Chabot resolved SHINDIG-590.
----------------------------------
Resolution: Fixed
While indeed the JS container doesn't get a lot of attention, that doesn't mean we can't accept a patch for a minor improvement :)
Applied & committed.
> javascript operators correctio
> ------------------------------
>
> Key: SHINDIG-590
> URL: https://issues.apache.org/jira/browse/SHINDIG-590
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript)
> Reporter: Guido Barosio
> Attachments: javascript_operators.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.