[GitHub] [nifi] MikeThomsen commented on a change in pull request #4853: Remove APT cache for Dockerfile

[GitBox <gi...@apache.org>]

MikeThomsen commented on a change in pull request #4853:
URL: https://github.com/apache/nifi/pull/4853#discussion_r584285517



##########
File path: nifi-docker/dockermaven/Dockerfile
##########
@@ -69,7 +69,9 @@ ENV NIFI_LOG_DIR=${NIFI_HOME}/logs
 RUN groupadd -g ${GID} nifi || groupmod -n nifi `getent group ${GID} | cut -d: -f1` \
     && useradd --shell /bin/bash -u ${UID} -g ${GID} -m nifi \
     && apt-get update \
-    && apt-get install -y jq xmlstarlet procps
+    && apt-get install -y jq xmlstarlet procps \
+    && apt-get clean  \
+    && rm -rf /var/lib/apt/lists/*

Review comment:
       This step removes the apt lists which is an unnecessary step that could cause confusion for people who extend the docker image.

##########
File path: nifi-docker/dockerhub/Dockerfile
##########
@@ -44,7 +44,9 @@ RUN groupadd -g ${GID} nifi || groupmod -n nifi `getent group ${GID} | cut -d: -
     && mkdir -p ${NIFI_BASE_DIR} \
     && chown -R nifi:nifi ${NIFI_BASE_DIR} \
     && apt-get update \
-    && apt-get install -y jq xmlstarlet procps
+    && apt-get install -y jq xmlstarlet procps \
+    && apt-get clean  \
+    && rm -rf /var/lib/apt/lists/*

Review comment:
       This step removes the apt lists which is an unnecessary step that could cause confusion for people who extend the docker image.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org