You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Olivier Lamy <ol...@apache.org> on 2011/02/12 00:02:36 UTC
Re: svn commit: r1069935 - /maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleDependencyResolver.java
Hello,
I wonder if we could have some documentation in the javadoc of
EventSpy for the method :
void onEvent( Object event )
throws Exception;
Because without navigating in the code it's a little bit mysterious to
know what type of events are "monitored" here.
Thanks
--
Olivier Lamy
http://twitter.com/olamy
http://www.linkedin.com/in/olamy
2011/2/11 <be...@apache.org>:
> Author: bentmann
> Date: Fri Feb 11 20:04:37 2011
> New Revision: 1069935
>
> URL: http://svn.apache.org/viewvc?rev=1069935&view=rev
> Log:
> o Allowed event spy to monitor project dependency graph
>
> Modified:
> maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleDependencyResolver.java
>
> Modified: maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleDependencyResolver.java
> URL: http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleDependencyResolver.java?rev=1069935&r1=1069934&r2=1069935&view=diff
> ==============================================================================
> --- maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleDependencyResolver.java (original)
> +++ maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleDependencyResolver.java Fri Feb 11 20:04:37 2011
> @@ -19,6 +19,7 @@ import org.apache.maven.RepositoryUtils;
> import org.apache.maven.artifact.Artifact;
> import org.apache.maven.artifact.ArtifactUtils;
> import org.apache.maven.artifact.factory.ArtifactFactory;
> +import org.apache.maven.eventspy.internal.EventSpyDispatcher;
> import org.apache.maven.execution.MavenSession;
> import org.apache.maven.lifecycle.LifecycleExecutionException;
> import org.apache.maven.project.DefaultDependencyResolutionRequest;
> @@ -61,6 +62,9 @@ public class LifecycleDependencyResolver
> @Requirement
> private ArtifactFactory artifactFactory;
>
> + @Requirement
> + private EventSpyDispatcher eventSpyDispatcher;
> +
> @SuppressWarnings({"UnusedDeclaration"})
> public LifecycleDependencyResolver()
> {
> @@ -162,6 +166,8 @@ public class LifecycleDependencyResolver
> new DefaultDependencyResolutionRequest( project, session.getRepositorySession() );
> request.setResolutionFilter( resolutionFilter );
>
> + eventSpyDispatcher.onEvent( request );
> +
> result = dependenciesResolver.resolve( request );
> }
> catch ( DependencyResolutionException e )
> @@ -191,6 +197,8 @@ public class LifecycleDependencyResolver
> }
> }
>
> + eventSpyDispatcher.onEvent( result );
> +
> Set<Artifact> artifacts = new LinkedHashSet<Artifact>();
> if ( result.getDependencyGraph() != null && !result.getDependencyGraph().getChildren().isEmpty() )
> {
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org