You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mnemonic.apache.org by "katarinaking (via GitHub)" <gi...@apache.org> on 2023/08/15 21:04:36 UTC
[GitHub] [mnemonic] katarinaking opened a new pull request, #344: MNEMONIC-793: Optimising performance of buildEntityMethodSpecs
katarinaking opened a new pull request, #344:
URL: https://github.com/apache/mnemonic/pull/344
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mnemonic.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mnemonic] bigdata-memory commented on a diff in pull request #344: MNEMONIC-793: Optimising performance of buildEntityMethodSpecs
Posted by "bigdata-memory (via GitHub)" <gi...@apache.org>.
bigdata-memory commented on code in PR #344:
URL: https://github.com/apache/mnemonic/pull/344#discussion_r1299219565
##########
mnemonic-core/src/main/java/org/apache/mnemonic/AnnotatedDurableEntityClass.java:
##########
@@ -931,7 +931,7 @@ protected void buildEntityMethodSpecs(TypeSpec.Builder typespecbuilder) throws A
// if (isUnboxPrimitive(dynfieldinfo.type)) {
// code.addStatement("$1N($2L)", gsetterName(fname, false),
// getIntialValueLiteral(dynfieldinfo.type));
- // } else {
+ // } else {TypeSpec
Review Comment:
Please remove this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mnemonic.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mnemonic] bigdata-memory merged pull request #344: MNEMONIC-793: Optimising performance of buildEntityMethodSpecs
Posted by "bigdata-memory (via GitHub)" <gi...@apache.org>.
bigdata-memory merged PR #344:
URL: https://github.com/apache/mnemonic/pull/344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mnemonic.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mnemonic] katarinaking commented on pull request #344: MNEMONIC-793: Optimising performance of buildEntityMethodSpecs
Posted by "katarinaking (via GitHub)" <gi...@apache.org>.
katarinaking commented on PR #344:
URL: https://github.com/apache/mnemonic/pull/344#issuecomment-1685051507
GGGGOOOOTTTT IT REMOVED BOSS !!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mnemonic.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org