[jira] [Commented] (AIRFLOW-3578) BigQueryOperator Type Error

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16729746#comment-16729746 ] 

ASF GitHub Bot commented on AIRFLOW-3578:
-----------------------------------------

kaxil commented on pull request #4384: [AIRFLOW-3578] Fix Type Error for BigQueryOperator
URL: https://github.com/apache/incubator-airflow/pull/4384
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. 
     - https://issues.apache.org/jira/browse/AIRFLOW-3578
   
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   The error is because it just checks for `str` type and not `unicode`
   
   **Error**:
   ```
   [2018-12-27 13:33:08,756] {__init__.py:1548} ERROR - query argument must have a type <type 'str'> not <type 'unicode'>
   Traceback (most recent call last):
     File "/Users/kaxil/Documents/GitHub/incubator-airflow/airflow/models/__init__.py", line 1431, in _run_raw_task
       result = task_copy.execute(context=context)
     File "/Users/kaxil/Documents/GitHub/incubator-airflow/airflow/contrib/operators/bigquery_operator.py", line 176, in execute
       cluster_fields=self.cluster_fields,
     File "/Users/kaxil/Documents/GitHub/incubator-airflow/airflow/contrib/hooks/bigquery_hook.py", line 677, in run_query
       param_type)
     File "/Users/kaxil/Documents/GitHub/incubator-airflow/airflow/contrib/hooks/bigquery_hook.py", line 1903, in _validate_value
       key, expected_type, type(value)))
   TypeError: query argument must have a type <type 'str'> not <type 'unicode'>
   ```
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Added tests
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> BigQueryOperator Type Error
> ---------------------------
>
>                 Key: AIRFLOW-3578
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3578
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Kaxil Naik
>            Assignee: Kaxil Naik
>            Priority: Minor
>             Fix For: 1.10.2
>
>
> The error is because it just checks for `str` type and not unicode
> *Error*:
> {noformat}
> [2018-12-27 13:33:08,756] {__init__.py:1548} ERROR - query argument must have a type <type 'str'> not <type 'unicode'>
> Traceback (most recent call last):
>   File "/Users/kaxil/Documents/GitHub/incubator-airflow/airflow/models/__init__.py", line 1431, in _run_raw_task
>     result = task_copy.execute(context=context)
>   File "/Users/kaxil/Documents/GitHub/incubator-airflow/airflow/contrib/operators/bigquery_operator.py", line 176, in execute
>     cluster_fields=self.cluster_fields,
>   File "/Users/kaxil/Documents/GitHub/incubator-airflow/airflow/contrib/hooks/bigquery_hook.py", line 677, in run_query
>     param_type)
>   File "/Users/kaxil/Documents/GitHub/incubator-airflow/airflow/contrib/hooks/bigquery_hook.py", line 1903, in _validate_value
>     key, expected_type, type(value)))
> TypeError: query argument must have a type <type 'str'> not <type 'unicode'>
> {noformat}
> To Recreate the error, try the following code:
> {code:python}
> import airflow
> from airflow import DAG
> from airflow.contrib.operators.bigquery_operator import BigQueryOperator
> default_args = {
>     'owner': 'airflow',
>     'depends_on_past': False,
>     'start_date': airflow.utils.dates.days_ago(2),
> }
> dag = DAG(
>     dag_id='airflow_dag_2',
>     default_args=default_args,
>     schedule_interval=None,
> )
> task_one = BigQueryOperator(
>     task_id='task_one',
>     sql='select * from airport.airport',
>     bigquery_conn_id='bigquery_conn',
>     dag=dag
> )
> task_one
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)