[PR] fix: sync Forge AWS GitHub deploy with working 8.0.x [grails-core]

["jamesfredley (via GitHub)" <gi...@apache.org>]

jamesfredley opened a new pull request, #16263:
URL: https://github.com/apache/grails-core/pull/16263

   Sync Forge AWS GitHub deploy with working 8.0.x
   
   Copy forge-deploy-aws.yml (no --process, fail fast on EB errors) and
   shared.yaml GitHubDeployRole managed policies from 8.0.x.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: sync Forge AWS GitHub deploy with working 8.0.x [grails-core]

["Copilot (via GitHub)" <gi...@apache.org>]

Copilot commented on code in PR #16263:
URL: https://github.com/apache/grails-core/pull/16263#discussion_r3885161366


##########
.github/workflows/forge-deploy-aws.yml:
##########
@@ -163,9 +163,18 @@ jobs:
           wait_for_ready_green() {
             local operation="$1"
             local expected_version="$2"
-            local status health current_version attempt
+            local status health current_version attempt event
+            local start_iso

Review Comment:
   `wait_for_ready_green` always sets `start_iso` when the function begins. Since the function is called after `update-environment`, any ERROR event emitted between the update call and the function start can be missed, which undermines the intended "fail fast on EB errors" behavior. Accept an optional start timestamp so the caller can set it before initiating the deployment operation.
   
   This issue also appears on line 205 of the same file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: sync Forge AWS GitHub deploy with working 8.0.x [grails-core]

["bito-code-review[bot] (via GitHub)" <gi...@apache.org>]

bito-code-review[bot] commented on PR #16263:
URL: https://github.com/apache/grails-core/pull/16263#issuecomment-5459720946

   <!-- Bito Reply -->
   To address the issue where `wait_for_ready_green` misses ERROR events emitted between the `update-environment` call and the function start, you should modify the function to accept an optional `start_iso` timestamp. This allows the caller to capture the timestamp before initiating the deployment and pass it into the function.
   
   Here is the suggested update for the function definition:
   
   ```yaml
             wait_for_ready_green() {
               local operation="$1"
               local expected_version="$2"
               local start_iso="${3:-$(date -u +%Y-%m-%dT%H:%M:%SZ)}"
               local status health current_version attempt event
               for attempt in {1..90};
   ```
   
   By defaulting `start_iso` to the current time if not provided, you maintain backward compatibility while enabling the caller to pass a pre-deployment timestamp to ensure no events are missed.
   
   **.github/workflows/forge-deploy-aws.yml**
   ```
   wait_for_ready_green() {
               local operation="$1"
               local expected_version="$2"
               local start_iso="${3:-$(date -u +%Y-%m-%dT%H:%M:%SZ)}"
               local status health current_version attempt event
               for attempt in {1..90}; do
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: sync Forge AWS GitHub deploy with working 8.0.x [grails-core]

["jamesfredley (via GitHub)" <gi...@apache.org>]

jamesfredley merged PR #16263:
URL: https://github.com/apache/grails-core/pull/16263


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org