[GitHub] [hbase] apurtell commented on a diff in pull request #4338: HBASE-26938 Compaction failures after StoreFileTracker integration

[GitBox <gi...@apache.org>]

apurtell commented on code in PR #4338:
URL: https://github.com/apache/hbase/pull/4338#discussion_r848580369


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java:
##########
@@ -1157,11 +1154,6 @@ protected List<HStoreFile> doCompaction(CompactionRequestImpl cr,
     }
     replaceStoreFiles(filesToCompact, sfs, true);
 
-    // This step is necessary for the correctness of BrokenStoreFileCleanerChore. It lets the
-    // CleanerChore know that compaction is done and the file can be cleaned up if compaction
-    // have failed.
-    storeEngine.resetCompactionWriter();

Review Comment:
   We can leave it in the API, but the current implementation only set the 'writer' field to null. The method body becomes empty when that field is converted into a parameter. 
   
   If we are going to keep it, we somehow need to pass a key as a parameter to abort and remove a StoreFileWriter instance from the new Set that holds them while the compactions are in progress. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org