[GitHub] [skywalking-client-js] wu-sheng commented on a change in pull request #23: feat: trace segments and set http header

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #23:
URL: https://github.com/apache/skywalking-client-js/pull/23#discussion_r549229726



##########
File path: src/errors/ajax.ts
##########
@@ -28,7 +28,7 @@ class AjaxErrors extends Base {
     const xhrSend = XMLHttpRequest.prototype.send;
     const xhrEvent = (event: any) => {
       try {
-        if (event && event.currentTarget && event.currentTarget.status !== 200) {
+        if (event && event.currentTarget && event.currentTarget.status !== 200 && event.currentTarget.status !== 304) {

Review comment:
       Yes, `>=400` is correct check. 202 is also correct, 302 is only redirect.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org