[mina-sshd] branch master updated: Improve logging of KEX negotiation result

[tw...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

twolf pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mina-sshd.git


The following commit(s) were added to refs/heads/master by this push:
     new 0eb40a4  Improve logging of KEX negotiation result
0eb40a4 is described below

commit 0eb40a4e162dddb0a38bafa12713856ad7ce1ce0
Author: Thomas Wolf <tw...@apache.org>
AuthorDate: Sat Jun 19 14:42:08 2021 +0200

    Improve logging of KEX negotiation result
    
    Log all values, not just a few.
---
 .../apache/sshd/common/session/helpers/AbstractSession.java    | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java b/sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java
index 7a01066..14da167 100644
--- a/sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java
+++ b/sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java
@@ -1927,14 +1927,8 @@ public abstract class AbstractSession extends SessionHelper {
         }
 
         if (log.isDebugEnabled()) {
-            log.debug("setNegotiationResult({}) Kex: server->client {} {} {}", this,
-                    guess.get(KexProposalOption.S2CENC),
-                    guess.get(KexProposalOption.S2CMAC),
-                    guess.get(KexProposalOption.S2CCOMP));
-            log.debug("setNegotiationResult({}) Kex: client->server {} {} {}", this,
-                    guess.get(KexProposalOption.C2SENC),
-                    guess.get(KexProposalOption.C2SMAC),
-                    guess.get(KexProposalOption.C2SCOMP));
+            guess.forEach((option, value) -> log.debug("setNegotiationResult({}) Kex: {} = {}", this,
+                    option.getDescription(), value));
         }
 
         return guess;