[GitHub] [airflow] mik-laj commented on a change in pull request #9354: Task logging handlers can provide custom log links

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #9354:
URL: https://github.com/apache/airflow/pull/9354#discussion_r441849111



##########
File path: airflow/utils/log/logging_mixin.py
##########
@@ -58,6 +58,20 @@ def _set_context(self, context):
             set_context(self.log, context)
 
 
+class RemoteLoggingMixin:
+    """
+    Define a logging handler based on a remote service (e.g. ELK, StackDriver). Subclasses must override
+    REMOTE_LOG_NAME and get_remote_log_url().
+    """
+    REMOTE_LOG_NAME: str = 'RemoteLog'

Review comment:
       ```suggestion
       def log_name(self):
           raise NotImplementedError('Remote logger must provide remote name')
   ```
   This will force the user to configure the name.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org