[GitHub] [incubator-superset] nytai commented on a change in pull request #8654: adds react-router to welcome component

[GitBox <gi...@apache.org>]

nytai commented on a change in pull request #8654: adds react-router to welcome component
URL: https://github.com/apache/incubator-superset/pull/8654#discussion_r350503050
 
 

 ##########
 File path: superset/assets/src/welcome/App.jsx
 ##########
 @@ -16,42 +16,47 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import React from 'react';
-import { hot } from 'react-hot-loader';
-import thunk from 'redux-thunk';
-import { createStore, applyMiddleware, compose, combineReducers } from 'redux';
-import { Provider } from 'react-redux';
+import React from "react";
+import { hot } from "react-hot-loader";
+import thunk from "redux-thunk";
+import { createStore, applyMiddleware, compose, combineReducers } from "redux";
+import { Provider } from "react-redux";
+import { BrowserRouter as Router, Switch, Route, Link } from "react-router-dom";
 
-import messageToastReducer from '../messageToasts/reducers';
-import { initEnhancer } from '../reduxUtils';
-import setupApp from '../setup/setupApp';
-import Welcome from './Welcome';
-import Menu from '../components/Menu/Menu';
+import messageToastReducer from "../messageToasts/reducers";
+import { initEnhancer } from "../reduxUtils";
+import setupApp from "../setup/setupApp";
+import Welcome from "./Welcome";
+import Menu from "../components/Menu/Menu";
 
 Review comment:
   Looks like prettier auto formatted this for me. I'll rerun once https://github.com/apache/incubator-superset/pull/8648 lands and the desired config is available. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org