You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/11/13 15:06:43 UTC
[kudu-CR] [test] Clear the KuduClientCache between tests
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11924
Change subject: [test] Clear the KuduClientCache between tests
......................................................................
[test] Clear the KuduClientCache between tests
The KuduClientCache is a Scala object, effectively
a singleton, that will live across tests. If the cache
is not cleared between tests, client state and
configurations could carry over from another test
and cause failures that are difficult to debug.
Change-Id: I1d989c00f9b0407e1db4b11df68080ef20cd471c
---
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/11924/1
--
To view, visit http://gerrit.cloudera.org:8080/11924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d989c00f9b0407e1db4b11df68080ef20cd471c
Gerrit-Change-Number: 11924
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [test] Clear the KuduClientCache between tests
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11924 )
Change subject: [test] Clear the KuduClientCache between tests
......................................................................
[test] Clear the KuduClientCache between tests
The KuduClientCache is a Scala object, effectively
a singleton, that will live across tests. If the cache
is not cleared between tests, client state and
configurations could carry over from another test
and cause failures that are difficult to debug.
Change-Id: I1d989c00f9b0407e1db4b11df68080ef20cd471c
Reviewed-on: http://gerrit.cloudera.org:8080/11924
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d989c00f9b0407e1db4b11df68080ef20cd471c
Gerrit-Change-Number: 11924
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] Clear the KuduClientCache between tests
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11924 )
Change subject: [test] Clear the KuduClientCache between tests
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11924/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11924/1//COMMIT_MSG@10
PS1, Line 10: If the cache
: is not cleared between tests, client state and
: configurations could carry over from another test
: and cause failures that are difficult to debug.
> I think this change is a good idea, but do we have any proof of this?
I don't have specific proof no. Given your other fix, it's difficult to tell if this was or could occur concretely.
--
To view, visit http://gerrit.cloudera.org:8080/11924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d989c00f9b0407e1db4b11df68080ef20cd471c
Gerrit-Change-Number: 11924
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 13 Nov 2018 18:46:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] [test] Clear the KuduClientCache between tests
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11924 )
Change subject: [test] Clear the KuduClientCache between tests
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11924/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11924/1//COMMIT_MSG@10
PS1, Line 10: If the cache
: is not cleared between tests, client state and
: configurations could carry over from another test
: and cause failures that are difficult to debug.
I think this change is a good idea, but do we have any proof of this?
--
To view, visit http://gerrit.cloudera.org:8080/11924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d989c00f9b0407e1db4b11df68080ef20cd471c
Gerrit-Change-Number: 11924
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 13 Nov 2018 18:45:21 +0000
Gerrit-HasComments: Yes