You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2019/11/06 17:06:25 UTC

[GitHub] [incubator-tvm] yinghai commented on a change in pull request #4243: Fix broken loop partitioning due to recent changes.

yinghai commented on a change in pull request #4243: Fix broken loop partitioning due to recent changes.
URL: https://github.com/apache/incubator-tvm/pull/4243#discussion_r343217657
 
 

 ##########
 File path: src/pass/loop_partition.cc
 ##########
 @@ -513,17 +513,19 @@ Stmt LoopPartitioner::TryPartition(const Node* node,
   bool pre_stmt_recurse = true;
   if (middle_interval_i->HasLowerBound()) {
     body_begin = ir::Simplify(middle_interval.min());
-    Expr cond = (body_begin - min >= 0);
 
 Review comment:
   @umangyadav I agree we might need a cleanup pass. But if we can avoid generating zero extent loops, it's desirable. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services