You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/06/21 10:08:38 UTC

[GitHub] [systemds] ywcb00 opened a new pull request #1321: [SYSTEMDS-3039] Federated Statistics

ywcb00 opened a new pull request #1321:
URL: https://github.com/apache/systemds/pull/1321


   Hi,
   This PR adds the functionality of collecting, aggregating, and displaying statistics of the federated workers.
   The following statistics are considered:
   * all the cache statistics
   * garbage collection statistics
   * heavy hitters
   * JIT times
   
   I introduced a new dml option _fedStats_ (similar to the existing _stats_ option) to enable the creation of federated statistics.
   To better seperate the federated statistics from the local statistics, I created a new class _FederatedStatistics_.
   
   Thanks for review :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] mboehm7 commented on pull request #1321: [SYSTEMDS-3039] Federated Statistics

Posted by GitBox <gi...@apache.org>.
mboehm7 commented on pull request #1321:
URL: https://github.com/apache/systemds/pull/1321#issuecomment-873633538


   LGTM - thanks for the patch @ywcb00. During the merge I converted print-based error handling into proper exception handling, and added the fedStats flag to at least one test (the existing federated statistics test was ignored and now serves both federated statistics and the other coordinator statistics related to federated transfers)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] asfgit closed pull request #1321: [SYSTEMDS-3039] Federated Statistics

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1321:
URL: https://github.com/apache/systemds/pull/1321


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org