You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/05 08:33:07 UTC

[GitHub] [airflow] Taragolis opened a new pull request, #28110: Fix instance name construction in GCP cloud memory sytem test

Taragolis opened a new pull request, #28110:
URL: https://github.com/apache/airflow/pull/28110

   Seems. like `SYSTEM_TESTS_ENV_ID` not set during `always` unittests in main
   
   ```
   FAILED tests/always/test_example_dags.py::test_should_be_importable[tests/system/providers/google/cloud/cloud_memorystore/example_cloud_memorystore_redis.py]
   
   ERROR    airflow.models.dagbag.DagBag:dagbag.py:343 Failed to import: /opt/airflow/tests/system/providers/google/cloud/cloud_memorystore/example_cloud_memorystore_redis.py
   Traceback (most recent call last):
     File "/opt/airflow/airflow/models/dagbag.py", line 339, in parse
       loader.exec_module(new_module)
     File "<frozen importlib._bootstrap_external>", line 850, in exec_module
     File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
     File "/opt/airflow/tests/system/providers/google/cloud/cloud_memorystore/example_cloud_memorystore_redis.py", line 57, in <module>
       MEMORYSTORE_REDIS_INSTANCE_NAME = f"redis-{ENV_ID.lower()}-1"
   AttributeError: 'NoneType' object has no attribute 'lower'
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal commented on pull request #28110: Fix instance name construction in GCP cloud memory sytem test

Posted by GitBox <gi...@apache.org>.
eladkal commented on PR #28110:
URL: https://github.com/apache/airflow/pull/28110#issuecomment-1337582987

   Fixed in https://github.com/apache/airflow/pull/28122 :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] Taragolis commented on pull request #28110: Fix instance name construction in GCP cloud memory sytem test

Posted by GitBox <gi...@apache.org>.
Taragolis commented on PR #28110:
URL: https://github.com/apache/airflow/pull/28110#issuecomment-1336954766

   cc: @bhirsz 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal closed pull request #28110: Fix instance name construction in GCP cloud memory sytem test

Posted by GitBox <gi...@apache.org>.
eladkal closed pull request #28110: Fix instance name construction in GCP cloud memory sytem test
URL: https://github.com/apache/airflow/pull/28110


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bhirsz commented on pull request #28110: Fix instance name construction in GCP cloud memory sytem test

Posted by GitBox <gi...@apache.org>.
bhirsz commented on PR #28110:
URL: https://github.com/apache/airflow/pull/28110#issuecomment-1336967025

   Thanks for the fix! This environment variable is set only under system tests so that makes sense its None for any other tests that reads the example (like the coverage tests). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org