You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Erick Erickson <er...@gmail.com> on 2014/09/20 22:28:13 UTC
Review Request 25876: SOLR-6512: Add a collections API call to
add/delete arbitrary roles to a specific replica
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25876/
-----------------------------------------------------------
Review request for lucene.
Repository: lucene
Description
-------
This patch allows one to add and delete a role on a specific replica. By default there is only one role allowed per slice, with the ability to override by specifying multiplePerSlice=true (defaults to false).
NOTE: Moving a few static strings around in this patch reflect Shalin's recent work in SOLR-6115: Cleanup enum/string action types in Overseer, OverseerCollectionProcessor and CollectionHandler.
Diffs
-----
trunk/solr/core/src/java/org/apache/solr/cloud/Overseer.java 1626491
trunk/solr/core/src/java/org/apache/solr/cloud/OverseerCollectionProcessor.java 1626491
trunk/solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java 1626491
trunk/solr/core/src/test/org/apache/solr/cloud/DeleteReplicaTest.java 1626491
trunk/solr/core/src/test/org/apache/solr/cloud/TestCollectionAPI.java 1626491
trunk/solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java 1626491
trunk/solr/solrj/src/java/org/apache/solr/common/params/CollectionParams.java 1626491
Diff: https://reviews.apache.org/r/25876/diff/
Testing
-------
Unit tests.
Thanks,
Erick Erickson
Re: Review Request 25876: SOLR-6512: Add a collections API call to
add/delete arbitrary roles to a specific replica
Posted by Erick Erickson <er...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25876/
-----------------------------------------------------------
(Updated Sept. 20, 2014, 8:29 p.m.)
Review request for lucene.
Repository: lucene
Description
-------
This patch allows one to add and delete a role on a specific replica. By default there is only one role allowed per slice, with the ability to override by specifying multiplePerSlice=true (defaults to false).
NOTE: Moving a few static strings around in this patch reflect Shalin's recent work in SOLR-6115: Cleanup enum/string action types in Overseer, OverseerCollectionProcessor and CollectionHandler.
Diffs
-----
trunk/solr/core/src/java/org/apache/solr/cloud/Overseer.java 1626491
trunk/solr/core/src/java/org/apache/solr/cloud/OverseerCollectionProcessor.java 1626491
trunk/solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java 1626491
trunk/solr/core/src/test/org/apache/solr/cloud/DeleteReplicaTest.java 1626491
trunk/solr/core/src/test/org/apache/solr/cloud/TestCollectionAPI.java 1626491
trunk/solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java 1626491
trunk/solr/solrj/src/java/org/apache/solr/common/params/CollectionParams.java 1626491
Diff: https://reviews.apache.org/r/25876/diff/
Testing
-------
Unit tests.
Thanks,
Erick Erickson
Re: Review Request 25876: SOLR-6512: Add a collections API call to
add/delete arbitrary roles to a specific replica
Posted by Erick Erickson <er...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25876/
-----------------------------------------------------------
(Updated Sept. 20, 2014, 8:28 p.m.)
Review request for lucene.
Repository: lucene
Description
-------
This patch allows one to add and delete a role on a specific replica. By default there is only one role allowed per slice, with the ability to override by specifying multiplePerSlice=true (defaults to false).
NOTE: Moving a few static strings around in this patch reflect Shalin's recent work in SOLR-6115: Cleanup enum/string action types in Overseer, OverseerCollectionProcessor and CollectionHandler.
Diffs
-----
trunk/solr/core/src/java/org/apache/solr/cloud/Overseer.java 1626491
trunk/solr/core/src/java/org/apache/solr/cloud/OverseerCollectionProcessor.java 1626491
trunk/solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java 1626491
trunk/solr/core/src/test/org/apache/solr/cloud/DeleteReplicaTest.java 1626491
trunk/solr/core/src/test/org/apache/solr/cloud/TestCollectionAPI.java 1626491
trunk/solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java 1626491
trunk/solr/solrj/src/java/org/apache/solr/common/params/CollectionParams.java 1626491
Diff: https://reviews.apache.org/r/25876/diff/
Testing
-------
Unit tests.
Thanks,
Erick Erickson