You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by "rafsun42 (via GitHub)" <gi...@apache.org> on 2023/01/30 18:20:47 UTC
[GitHub] [age] rafsun42 opened a new pull request, #638: Implement plus-equal operator in SET clause
rafsun42 opened a new pull request, #638:
URL: https://github.com/apache/age/pull/638
Additional changes:
Null properties are removed from cypher maps in certain cases. A new property `cypher_map.keep_null` is added. It is set while transforming CREATE, MATCH and SET clause. Based on its value, transform_cypher_map tells executor whether to keep the null properties in maps that appear in the mentioned clauses.
Cases of null removal:
- For CREATE and SET with equal operator, nulls are removed.
- For MATCH, nulls are not removed.
- For SET with plus-equal operator, nulls are kept during transformation, but removed after execution.
- For any other cases, nulls are removed by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani merged pull request #638: Implement plus-equal operator in SET clause
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani merged PR #638:
URL: https://github.com/apache/age/pull/638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani commented on a diff in pull request #638: Implement plus-equal operator in SET clause
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on code in PR #638:
URL: https://github.com/apache/age/pull/638#discussion_r1092600291
##########
src/include/nodes/cypher_nodes.h:
##########
@@ -195,6 +195,7 @@ typedef struct cypher_map
ExtensibleNode extensible;
List *keyvals;
int location;
+ int keep_null; // if false, keyvals with null value are removed
Review Comment:
Using an integer in place of a Boolean can be okay in some instances. I was just wondering because it looked like it was only ever used as a Boolean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] rafsun42 commented on a diff in pull request #638: Implement plus-equal operator in SET clause
Posted by "rafsun42 (via GitHub)" <gi...@apache.org>.
rafsun42 commented on code in PR #638:
URL: https://github.com/apache/age/pull/638#discussion_r1092596569
##########
src/include/nodes/cypher_nodes.h:
##########
@@ -195,6 +195,7 @@ typedef struct cypher_map
ExtensibleNode extensible;
List *keyvals;
int location;
+ int keep_null; // if false, keyvals with null value are removed
Review Comment:
@jrgemignani My bad. Fixed it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani commented on a diff in pull request #638: Implement plus-equal operator in SET clause
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on code in PR #638:
URL: https://github.com/apache/age/pull/638#discussion_r1091336720
##########
src/include/nodes/cypher_nodes.h:
##########
@@ -195,6 +195,7 @@ typedef struct cypher_map
ExtensibleNode extensible;
List *keyvals;
int location;
+ int keep_null; // if false, keyvals with null value are removed
Review Comment:
Why is this an integer and not a Boolean? It is preferable to use a Boolean type and true/false instead of 1/0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org