You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Chris Douglas (JIRA)" <ji...@apache.org> on 2009/03/17 07:10:50 UTC

[jira] Created: (HADOOP-5514) Add waiting/failed tasks to JobTracker metrics

Add waiting/failed tasks to JobTracker metrics
----------------------------------------------

                 Key: HADOOP-5514
                 URL: https://issues.apache.org/jira/browse/HADOOP-5514
             Project: Hadoop Core
          Issue Type: Improvement
          Components: mapred, metrics
            Reporter: Chris Douglas


In addition to launched and completed tasks, it would be helpful if the number of waiting tasks and failed tasks were accumulated as metrics.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5514) Add waiting/failed tasks to JobTracker metrics

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683085#action_12683085 ] 

Hudson commented on HADOOP-5514:
--------------------------------

Integrated in Hadoop-trunk #783 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/783/])
    . Fix JobTracker metrics and add metrics for wating, failed tasks.


> Add waiting/failed tasks to JobTracker metrics
> ----------------------------------------------
>
>                 Key: HADOOP-5514
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5514
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred, metrics
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>             Fix For: 0.20.0
>
>         Attachments: 5514-0.patch
>
>
> In addition to launched and completed tasks, it would be helpful if the number of waiting tasks and failed tasks were accumulated as metrics.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5514) Add waiting/failed tasks to JobTracker metrics

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-5514:
----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.20.0
     Hadoop Flags: [Reviewed]
           Status: Resolved  (was: Patch Available)

I committed this.

> Add waiting/failed tasks to JobTracker metrics
> ----------------------------------------------
>
>                 Key: HADOOP-5514
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5514
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred, metrics
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>             Fix For: 0.20.0
>
>         Attachments: 5514-0.patch
>
>
> In addition to launched and completed tasks, it would be helpful if the number of waiting tasks and failed tasks were accumulated as metrics.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5514) Add waiting/failed tasks to JobTracker metrics

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682882#action_12682882 ] 

Arun C Murthy commented on HADOOP-5514:
---------------------------------------

+1.

Eventually we should replace synchronized methods in JobTrackerMetricsInst with AtomicIntegers as applicable... I'd do it as a separate patch.

> Add waiting/failed tasks to JobTracker metrics
> ----------------------------------------------
>
>                 Key: HADOOP-5514
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5514
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred, metrics
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>         Attachments: 5514-0.patch
>
>
> In addition to launched and completed tasks, it would be helpful if the number of waiting tasks and failed tasks were accumulated as metrics.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5514) Add waiting/failed tasks to JobTracker metrics

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682820#action_12682820 ] 

Hadoop QA commented on HADOOP-5514:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12402356/5514-0.patch
  against trunk revision 755226.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/96/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/96/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/96/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/96/console

This message is automatically generated.

> Add waiting/failed tasks to JobTracker metrics
> ----------------------------------------------
>
>                 Key: HADOOP-5514
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5514
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred, metrics
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>         Attachments: 5514-0.patch
>
>
> In addition to launched and completed tasks, it would be helpful if the number of waiting tasks and failed tasks were accumulated as metrics.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5514) Add waiting/failed tasks to JobTracker metrics

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682941#action_12682941 ] 

Chris Douglas commented on HADOOP-5514:
---------------------------------------

Committed to 0.20 as well, since this fixes HADOOP-5499, a regression in the metrics.

> Add waiting/failed tasks to JobTracker metrics
> ----------------------------------------------
>
>                 Key: HADOOP-5514
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5514
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred, metrics
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>             Fix For: 0.20.0
>
>         Attachments: 5514-0.patch
>
>
> In addition to launched and completed tasks, it would be helpful if the number of waiting tasks and failed tasks were accumulated as metrics.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5514) Add waiting/failed tasks to JobTracker metrics

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-5514:
----------------------------------

    Attachment: 5514-0.patch

* Rather than passing JobTrackerInstrumentation through call chain, add an accessor to JT and use through ref kept by JobInProgress
* Fix HADOOP-5499 by moving launchMap/launchReduce accounting from JobTracker::createTaskEntry to JobInProgress::addRunningTaskToTIP
* Add waiting task accounting to JobInProgress::initTasks, JobInProgress::garbageCollect, and related metrics
* Add failed task accounting to JobInProgress::failedTask

Thanks to Deveraj for guidance on the JobTracker

> Add waiting/failed tasks to JobTracker metrics
> ----------------------------------------------
>
>                 Key: HADOOP-5514
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5514
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred, metrics
>            Reporter: Chris Douglas
>         Attachments: 5514-0.patch
>
>
> In addition to launched and completed tasks, it would be helpful if the number of waiting tasks and failed tasks were accumulated as metrics.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5514) Add waiting/failed tasks to JobTracker metrics

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-5514:
----------------------------------

    Assignee: Chris Douglas
      Status: Patch Available  (was: Open)

> Add waiting/failed tasks to JobTracker metrics
> ----------------------------------------------
>
>                 Key: HADOOP-5514
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5514
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred, metrics
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>         Attachments: 5514-0.patch
>
>
> In addition to launched and completed tasks, it would be helpful if the number of waiting tasks and failed tasks were accumulated as metrics.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.