You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by thisisbaozi <gi...@git.apache.org> on 2017/01/01 04:03:24 UTC
[GitHub] incubator-rocketmq pull request #26: [ROCKETMQ-26]add new way to send messag...
GitHub user thisisbaozi opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/26
[ROCKETMQ-26]add new way to send messages in asynchronous way
Jira issue: https://issues.apache.org/jira/browse/ROCKETMQ-26
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thisisbaozi/incubator-rocketmq master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/26.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #26
----
commit 67545d976c608211eeb07feca0b9e39b5f04c2b1
Author: thisisbaozi <th...@gmail.com>
Date: 2017-01-01T02:52:47Z
add new way to send message in asynchronous way
commit 0ddbc4471a6ed1305bade5bb5eb58c8182066990
Author: thisisbaozi <th...@gmail.com>
Date: 2017-01-01T03:39:44Z
[ROCKETMQ-26]add a new way to send message in asynchronous
commit 85eb28f0500bd2c73fefded7d845736b5d3fc46b
Author: thisisbaozi <th...@gmail.com>
Date: 2017-01-01T04:01:36Z
[ROCKETMQ-26]add new way to send messages in asynchronous way
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #26: [ROCKETMQ-26]add new way to send messag...
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/26#discussion_r94281902
--- Diff: client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultSendPromise.java ---
@@ -0,0 +1,302 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.client.impl.producer;
+
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.Executor;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import org.apache.rocketmq.client.log.ClientLogger;
+import org.apache.rocketmq.client.producer.SendCallback;
+import org.apache.rocketmq.client.producer.SendFuture;
+import org.apache.rocketmq.client.producer.SendResult;
+import org.slf4j.Logger;
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Created by stone
+ */
--- End diff --
No author info please, please refer to [here](http://rocketmq.apache.org/docs/code-guidelines/)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #26: [ROCKETMQ-26]add new way to send messages in a...
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/26
Thanks @thisisbaozi , we have introduced a new way for async behavior in the latest version. Could you give us some hint for this usage ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #26: [ROCKETMQ-26]add new way to send messag...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/26
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #26: [ROCKETMQ-26]add new way to send messages in a...
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/26
Thanks @thisisbaozi . RocketMQ 4.1 will publish a new async way to deal with the same requirement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #26: [ROCKETMQ-26]add new way to send messag...
Posted by thisisbaozi <gi...@git.apache.org>.
Github user thisisbaozi commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/26#discussion_r94282172
--- Diff: client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultSendPromise.java ---
@@ -0,0 +1,302 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.client.impl.producer;
+
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.Executor;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import org.apache.rocketmq.client.log.ClientLogger;
+import org.apache.rocketmq.client.producer.SendCallback;
+import org.apache.rocketmq.client.producer.SendFuture;
+import org.apache.rocketmq.client.producer.SendResult;
+import org.slf4j.Logger;
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Created by stone
+ */
--- End diff --
Removed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #26: [ROCKETMQ-26]add new way to send messages in a...
Posted by thisisbaozi <gi...@git.apache.org>.
Github user thisisbaozi commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/26
@vongosling I have added a example for it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---