[GitHub] [spark] jiangxb1987 commented on a change in pull request #28009: [SPARK-31235][YARN] Separates different categories of applications

[GitBox <gi...@apache.org>]

jiangxb1987 commented on a change in pull request #28009: [SPARK-31235][YARN] Separates different categories of applications
URL: https://github.com/apache/spark/pull/28009#discussion_r398083703
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala
 ##########
 @@ -332,6 +332,36 @@ class SparkSubmitSuite
     sys.props("SPARK_SUBMIT") should be ("true")
   }
 
+  test("handles spark.yarn.applicationType on yarn mode") {
+    val clArgs = Seq(
+      "--deploy-mode", "client",
+      "--master", "yarn",
+      "--executor-memory", "5g",
+      "--executor-cores", "5",
+      "--class", "org.SomeClass",
+      "--jars", "one.jar,two.jar,three.jar",
+      "--driver-memory", "4g",
+      "--queue", "thequeue",
+      "--files", "file1.txt,file2.txt",
+      "--archives", "archive1.txt,archive2.txt",
+      "--num-executors", "6",
+      "--name", "trill",
+      "--conf", "spark.yarn.applicationType=SPARK-SQL",
 
 Review comment:
   should you also test the case when `spark.yarn.applicationType` is not set?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org