[GitHub] [commons-crypto] aremily opened a new pull request #94: Crypto 137 windows compile

[GitBox <gi...@apache.org>]

aremily opened a new pull request #94: Crypto 137 windows compile
URL: https://github.com/apache/commons-crypto/pull/94
 
 
   Please review for inclusion to the master branch.  Addresses CRYPTO-137 and in the process cleans up a lot of changes introduced in the 1.1 support branch merge.  Build has been tested and passes for OpenSSL versions 1.0 and 1.1 on Windows and Linux, and 1.1 on OSX.  Might also address CRYPTO-139.
   
   Note that the Travis OSX build ships with LIbreSSL, and the LibreSSL build skips all the JNA tests.  Do we want to support LibreSSL?  If LibreSSL is the default brew install, it’s probably on a lot of Macs.  
   
   The Travis Windows build does not support Java, so I omitted it.  The Travis Ubuntu build does not yet support Bionic with its default OpenSSL 1.1 install, but I would recommend adding a Bionic build to the Travis matrix as soon as it’s supported.  Currently all the Travis builds are on OpenSSL 1.0, so 1.1 builds must be tested locally.
   
   Some of the line wrapping is inconsistent.  I prefer fewer breaks, so I made changes while I was troubleshooting that made the code easier for me to read.  I’d like to keep it that way, but understand that people can have strong feelings about it if you want it changed back.
   
   Java 8 is the last version that supports “javah”.  Subsequent versions will require javac -h, which does not support the same command line options as javah.  Something to consider if we want to support more recent releases of Java. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services