You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ma...@apache.org on 2018/05/10 03:42:22 UTC

[incubator-superset] branch master updated: superset/import_dashboards.html: Update title, clean up html (#4972)

This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 94249ed  superset/import_dashboards.html: Update title, clean up html (#4972)
94249ed is described below

commit 94249ed20c0dc5ca145e4c3ac04705e3bc900b57
Author: Nicole Dominguez <wo...@nicoledominguez.com>
AuthorDate: Wed May 9 23:42:17 2018 -0400

    superset/import_dashboards.html: Update title, clean up html (#4972)
    
    * Changes "Import the dashboards." to "Import dashboards"
    * Cleans up the HTML to add quotes, self close tags, etc.
    * Adds a class to the `<submit>` button to utilize bootstrap style
    * Remove the `<title>` tag in body as it's not vaild HTML and redundant with `{% block %}`
---
 superset/templates/superset/import_dashboards.html | 36 ++++++++++++----------
 1 file changed, 19 insertions(+), 17 deletions(-)

diff --git a/superset/templates/superset/import_dashboards.html b/superset/templates/superset/import_dashboards.html
index 383506f..14c7bd1 100644
--- a/superset/templates/superset/import_dashboards.html
+++ b/superset/templates/superset/import_dashboards.html
@@ -8,22 +8,24 @@
   {% endwith %}
 {% endblock %}
 
-{% block title %}{{ _("Import") }}{% endblock %}
+{% block title %}{{ _("Import dashboards") }}{% endblock %}
+
 {% block body %}
-    {% include "superset/flash_wrapper.html" %}
-    <div class="container">
-        <title>Import the dashboards.</title>
-        <h1>Import the dashboards.</h1>
-        <form method=post enctype=multipart/form-data>
-          <input
-            type="hidden"
-            name="csrf_token"
-            id="csrf_token"
-            value="{{ csrf_token() if csrf_token else '' }}"
-          >
-          <p><input type=file name=file>
-             <input type=submit value=Upload>
-          </p>
-        </form>
-    </div>
+  {% include "superset/flash_wrapper.html" %}
+
+  <div class="container">
+    <h1>Import dashboards</h1>
+
+    <form method="post" enctype="multipart/form-data">
+      <input
+      type="hidden"
+      name="csrf_token"
+      id="csrf_token"
+      value="{{ csrf_token() if csrf_token else '' }}" />
+      <p>
+        <input type="file" name="file" />
+        <input type="submit" value="Upload" class="btn" />
+      </p>
+    </form>
+  </div>
 {% endblock %}

-- 
To stop receiving notification emails like this one, please contact
maximebeauchemin@apache.org.