You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@archiva.apache.org by "Wendy Smoak (JIRA)" <ji...@codehaus.org> on 2009/04/15 22:34:57 UTC

[jira] Created: (MRM-1172) Invalid version validation error when uploading a jar with a four-part version number

Invalid version validation error when uploading a jar with a four-part version number
-------------------------------------------------------------------------------------

                 Key: MRM-1172
                 URL: http://jira.codehaus.org/browse/MRM-1172
             Project: Archiva
          Issue Type: Bug
          Components: web application
    Affects Versions: 1.2.1
            Reporter: Wendy Smoak
            Priority: Minor


Archiva will not allow you to upload an artifact with a version number in the format 2.5-r123456-proj-1.2.3

We use this version number format to do internal releases of third-party artifacts.

Deploying from the command line works, but the artifact upload form in Archiva will not accept this version number and displays "Invalid version".


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRM-1172) Invalid version validation error when uploading a jar with a four-part version number

Posted by "jan ancajas (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

jan ancajas updated MRM-1172:
-----------------------------

    Attachment: MRM-1172.patch

attach patch for the proposed solution.

> Invalid version validation error when uploading a jar with a four-part version number
> -------------------------------------------------------------------------------------
>
>                 Key: MRM-1172
>                 URL: http://jira.codehaus.org/browse/MRM-1172
>             Project: Archiva
>          Issue Type: Bug
>          Components: web application
>    Affects Versions: 1.2.1
>         Environment: Archiva 1.2.1-SNAPSHOT trunk r761865
>            Reporter: Wendy Smoak
>            Priority: Minor
>             Fix For: 1.2.1
>
>         Attachments: MRM-1172.patch
>
>
> Archiva will not allow you to upload an artifact with a version number in the format 2.5-r123456-proj-1.2.3
> We use this version number format to do internal releases of third-party artifacts.
> Deploying from the command line works, but the artifact upload form in Archiva will not accept this version number and displays "Invalid version".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRM-1172) Invalid version validation error when uploading a jar with a four-part version number

Posted by "Wendy Smoak (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRM-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=174340#action_174340 ] 

Wendy Smoak commented on MRM-1172:
----------------------------------

Is there logic somewhere in Maven to decide whether a version number is valid?   Why would Archiva be more strict about this?

I've never had a build fail due to an invalid version number... it may not be able to find the dependency, and creative version number formats don't work well with ranges, but not invalid.


> Invalid version validation error when uploading a jar with a four-part version number
> -------------------------------------------------------------------------------------
>
>                 Key: MRM-1172
>                 URL: http://jira.codehaus.org/browse/MRM-1172
>             Project: Archiva
>          Issue Type: Bug
>          Components: web application
>    Affects Versions: 1.2.1
>         Environment: Archiva 1.2.1-SNAPSHOT trunk r761865
>            Reporter: Wendy Smoak
>            Priority: Minor
>             Fix For: 1.2.1
>
>         Attachments: MRM-1172.patch
>
>
> Archiva will not allow you to upload an artifact with a version number in the format 2.5-r123456-proj-1.2.3
> We use this version number format to do internal releases of third-party artifacts.
> Deploying from the command line works, but the artifact upload form in Archiva will not accept this version number and displays "Invalid version".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRM-1172) Invalid version validation error when uploading a jar with a four-part version number

Posted by "jan ancajas (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRM-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=174549#action_174549 ] 

jan ancajas commented on MRM-1172:
----------------------------------

maven deploy plugin doesn't have this checking. it's only in archiva

> Invalid version validation error when uploading a jar with a four-part version number
> -------------------------------------------------------------------------------------
>
>                 Key: MRM-1172
>                 URL: http://jira.codehaus.org/browse/MRM-1172
>             Project: Archiva
>          Issue Type: Bug
>          Components: web application
>    Affects Versions: 1.2.1
>         Environment: Archiva 1.2.1-SNAPSHOT trunk r761865
>            Reporter: Wendy Smoak
>            Priority: Minor
>             Fix For: 1.2.1
>
>         Attachments: MRM-1172.patch
>
>
> Archiva will not allow you to upload an artifact with a version number in the format 2.5-r123456-proj-1.2.3
> We use this version number format to do internal releases of third-party artifacts.
> Deploying from the command line works, but the artifact upload form in Archiva will not accept this version number and displays "Invalid version".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRM-1172) Invalid version validation error when uploading a jar with a four-part version number

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter updated MRM-1172:
------------------------------

    Fix Version/s: 1.2.1

> Invalid version validation error when uploading a jar with a four-part version number
> -------------------------------------------------------------------------------------
>
>                 Key: MRM-1172
>                 URL: http://jira.codehaus.org/browse/MRM-1172
>             Project: Archiva
>          Issue Type: Bug
>          Components: web application
>    Affects Versions: 1.2.1
>            Reporter: Wendy Smoak
>            Priority: Minor
>             Fix For: 1.2.1
>
>
> Archiva will not allow you to upload an artifact with a version number in the format 2.5-r123456-proj-1.2.3
> We use this version number format to do internal releases of third-party artifacts.
> Deploying from the command line works, but the artifact upload form in Archiva will not accept this version number and displays "Invalid version".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRM-1172) Invalid version validation error when uploading a jar with a four-part version number

Posted by "jan ancajas (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRM-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=174289#action_174289 ] 

jan ancajas commented on MRM-1172:
----------------------------------

>From what I've traced this has something to do with the version algorithm implementation :
1. tokenize the string  using "-" (dash) as the separator
2. checks if each token matches the regex pattern (see below)
3. the  token ratio  between "matching tokens" and "all tokens" must be 75% or more.

>From the example it's only 50%.

We can loosen the rule a bit  to return true if the first token  is a matching token. thoughts on this ?


{noformat}
        "([0-9][_.0-9a-z]*)",
        "(snapshot)",
        "(g?[_.0-9ab]*(pre|rc|g|m)[_.0-9]*)",
        "(dev[_.0-9]*)",
        "(alpha[_.0-9]*)",
        "(beta[_.0-9]*)",
        "(rc[_.0-9]*)",
        "(debug[_.0-9]*)",
        "(unofficial[_.0-9]*)",
        "(current)",
        "(latest)",
        "(fcs)",
        "(release[_.0-9]*)",
        "(nightly)",
        "(final)",
        "(incubating)",
        "(incubator)",
        "([ab][_.0-9]+)"
{noformat}

> Invalid version validation error when uploading a jar with a four-part version number
> -------------------------------------------------------------------------------------
>
>                 Key: MRM-1172
>                 URL: http://jira.codehaus.org/browse/MRM-1172
>             Project: Archiva
>          Issue Type: Bug
>          Components: web application
>    Affects Versions: 1.2.1
>         Environment: Archiva 1.2.1-SNAPSHOT trunk r761865
>            Reporter: Wendy Smoak
>            Priority: Minor
>             Fix For: 1.2.1
>
>
> Archiva will not allow you to upload an artifact with a version number in the format 2.5-r123456-proj-1.2.3
> We use this version number format to do internal releases of third-party artifacts.
> Deploying from the command line works, but the artifact upload form in Archiva will not accept this version number and displays "Invalid version".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MRM-1172) Invalid version validation error when uploading a jar with a four-part version number

Posted by "Maria Odea Ching (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maria Odea Ching closed MRM-1172.
---------------------------------

    Resolution: Fixed

Updated documentation in trunk -r778123.

> Invalid version validation error when uploading a jar with a four-part version number
> -------------------------------------------------------------------------------------
>
>                 Key: MRM-1172
>                 URL: http://jira.codehaus.org/browse/MRM-1172
>             Project: Archiva
>          Issue Type: Bug
>          Components: web application
>    Affects Versions: 1.2.1
>         Environment: Archiva 1.2.1-SNAPSHOT trunk r761865
>            Reporter: Wendy Smoak
>            Assignee: Maria Odea Ching
>            Priority: Minor
>             Fix For: 1.2.1
>
>         Attachments: MRM-1172-2.patch, MRM-1172.patch
>
>
> Archiva will not allow you to upload an artifact with a version number in the format 2.5-r123456-proj-1.2.3
> We use this version number format to do internal releases of third-party artifacts.
> Deploying from the command line works, but the artifact upload form in Archiva will not accept this version number and displays "Invalid version".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRM-1172) Invalid version validation error when uploading a jar with a four-part version number

Posted by "Maria Odea Ching (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRM-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=175242#action_175242 ] 

Maria Odea Ching commented on MRM-1172:
---------------------------------------

Patch applied to trunk -r772151. Thanks Jan! 

Leaving this issue for the documentation patch..

> Invalid version validation error when uploading a jar with a four-part version number
> -------------------------------------------------------------------------------------
>
>                 Key: MRM-1172
>                 URL: http://jira.codehaus.org/browse/MRM-1172
>             Project: Archiva
>          Issue Type: Bug
>          Components: web application
>    Affects Versions: 1.2.1
>         Environment: Archiva 1.2.1-SNAPSHOT trunk r761865
>            Reporter: Wendy Smoak
>            Priority: Minor
>             Fix For: 1.2.1
>
>         Attachments: MRM-1172-2.patch, MRM-1172.patch
>
>
> Archiva will not allow you to upload an artifact with a version number in the format 2.5-r123456-proj-1.2.3
> We use this version number format to do internal releases of third-party artifacts.
> Deploying from the command line works, but the artifact upload form in Archiva will not accept this version number and displays "Invalid version".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRM-1172) Invalid version validation error when uploading a jar with a four-part version number

Posted by "jan ancajas (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

jan ancajas updated MRM-1172:
-----------------------------

    Attachment: MRM-1172-2.patch

added UT. THanks:)

> Invalid version validation error when uploading a jar with a four-part version number
> -------------------------------------------------------------------------------------
>
>                 Key: MRM-1172
>                 URL: http://jira.codehaus.org/browse/MRM-1172
>             Project: Archiva
>          Issue Type: Bug
>          Components: web application
>    Affects Versions: 1.2.1
>         Environment: Archiva 1.2.1-SNAPSHOT trunk r761865
>            Reporter: Wendy Smoak
>            Priority: Minor
>             Fix For: 1.2.1
>
>         Attachments: MRM-1172-2.patch, MRM-1172.patch
>
>
> Archiva will not allow you to upload an artifact with a version number in the format 2.5-r123456-proj-1.2.3
> We use this version number format to do internal releases of third-party artifacts.
> Deploying from the command line works, but the artifact upload form in Archiva will not accept this version number and displays "Invalid version".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (MRM-1172) Invalid version validation error when uploading a jar with a four-part version number

Posted by "Maria Odea Ching (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maria Odea Ching reassigned MRM-1172:
-------------------------------------

    Assignee: Maria Odea Ching

> Invalid version validation error when uploading a jar with a four-part version number
> -------------------------------------------------------------------------------------
>
>                 Key: MRM-1172
>                 URL: http://jira.codehaus.org/browse/MRM-1172
>             Project: Archiva
>          Issue Type: Bug
>          Components: web application
>    Affects Versions: 1.2.1
>         Environment: Archiva 1.2.1-SNAPSHOT trunk r761865
>            Reporter: Wendy Smoak
>            Assignee: Maria Odea Ching
>            Priority: Minor
>             Fix For: 1.2.1
>
>         Attachments: MRM-1172-2.patch, MRM-1172.patch
>
>
> Archiva will not allow you to upload an artifact with a version number in the format 2.5-r123456-proj-1.2.3
> We use this version number format to do internal releases of third-party artifacts.
> Deploying from the command line works, but the artifact upload form in Archiva will not accept this version number and displays "Invalid version".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRM-1172) Invalid version validation error when uploading a jar with a four-part version number

Posted by "Wendy Smoak (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wendy Smoak updated MRM-1172:
-----------------------------

    Environment: Archiva 1.2.1-SNAPSHOT trunk r761865

> Invalid version validation error when uploading a jar with a four-part version number
> -------------------------------------------------------------------------------------
>
>                 Key: MRM-1172
>                 URL: http://jira.codehaus.org/browse/MRM-1172
>             Project: Archiva
>          Issue Type: Bug
>          Components: web application
>    Affects Versions: 1.2.1
>         Environment: Archiva 1.2.1-SNAPSHOT trunk r761865
>            Reporter: Wendy Smoak
>            Priority: Minor
>             Fix For: 1.2.1
>
>
> Archiva will not allow you to upload an artifact with a version number in the format 2.5-r123456-proj-1.2.3
> We use this version number format to do internal releases of third-party artifacts.
> Deploying from the command line works, but the artifact upload form in Archiva will not accept this version number and displays "Invalid version".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira