You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nuttx.apache.org by GitBox <gi...@apache.org> on 2019/12/31 22:35:46 UTC
[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #21: net:
tcp: Fix compile error in tcp.h
masayuki2009 opened a new pull request #21: net: tcp: Fix compile error in tcp.h
URL: https://github.com/apache/incubator-nuttx/pull/21
During build testing for spresense with the latest master, I encountered the following compile error.
```
tcp/tcp_netpoll.c: In function 'tcp_pollsetup':
./tcp/tcp.h:1191:42: error: expected ')' before ';' token
# define tcp_backlogavailable(c) (false);
^
tcp/tcp_netpoll.c:308:40: note: in expansion of macro 'tcp_backlogavailable'
if (!IOB_QEMPTY(&conn->readahead) || tcp_backlogavailable(conn))
^~~~~~~~~~~~~~~~~~~~
Makefile:102: recipe for target 'tcp_netpoll.o' failed
```
Actually, the line 1191 in tcp/tcp.h was added in 2014-07-06 but not used so far.
And the line 308 in tcp/tcp_netpoll.c was not called on my environment before merging the following commit
```
commit 90c52e6f8f7efce97ac718c0f98addc13ec880d2
Author: Xiang Xiao <xi...@xiaomi.com>
Date: Tue Dec 31 09:26:14 2019 -0600
````
The fix in this PR is very trivial and I think @xiaoxiang781216 enabled CONFIG_NET_TCPBACKLOG on his environments because he did not encounter the error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #21: net:
tcp: Fix compile error in tcp.h
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on issue #21: net: tcp: Fix compile error in tcp.h
URL: https://github.com/apache/incubator-nuttx/pull/21#issuecomment-570003155
@masayuki2009 Removing support for CONFIG_NET_TCPBACKLOG altogether might be a better solution? Anyone else have an opinion to the contrary?
The TCP backlog was conditioned originally only to support super-tiny networking. But with all of the growth in networking, I think super-tiny networking is not really an option and is certainly not advised in this case since the consequences of disabling backlog are so severe. NuttX now really only supports "small" networking, not super-tiny networking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] masayuki2009 commented on issue #21: net: tcp:
Fix compile error in tcp.h
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #21: net: tcp: Fix compile error in tcp.h
URL: https://github.com/apache/incubator-nuttx/pull/21#issuecomment-570004024
> @masayuki2009 Removing support for CONFIG_NET_TCPBACKLOG altogether might be a better solution? Anyone else have an opinion to the contrary?
>
> The TCP backlog was conditioned originally only to support super-tiny networking. But with all of the growth in networking, I think super-tiny networking is not really an option and is certainly not advised in this case since the consequences of disabling backlog are so severe. NuttX now really only supports "small" networking, not super-tiny networking.
@patacongo I think that's a good idea, because we will not use NuttX networking with super-tiny environment. If nobody has an objection on it, please remove support for CONFIG_NET_TCPBACKLOG.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #21: net: tcp: Fix
compile error in tcp.h
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #21: net: tcp: Fix compile error in tcp.h
URL: https://github.com/apache/incubator-nuttx/pull/21#issuecomment-570001685
BTW: CONFIG_NET_TCPBACKLOG probably should always be enabled. Otherwise, you will miss connection requests. That configuration is a candidate to be removed and just have connection backlog support enabled at all times.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #21: net: tcp: Fix
compile error in tcp.h
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #21: net: tcp: Fix compile error in tcp.h
URL: https://github.com/apache/incubator-nuttx/pull/21#issuecomment-570003155
@masayuki2009 Removing support for CONFIG_NET_TCPBACKLOG altogether might be a better solution? Anyone else have an opinion to the contrary?
The TCP backlog was conditioned originally only to support support super tiny networking. But with all of the growth in networking, I think super-tiny networking is not really an option and is certainly not advised in this case since the consequences of disabling backlog are so bad. NuttX now really only supports "small" networking, not super-tiny networking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] masayuki2009 commented on issue #21: net: tcp:
Fix compile error in tcp.h
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #21: net: tcp: Fix compile error in tcp.h
URL: https://github.com/apache/incubator-nuttx/pull/21#issuecomment-570002552
> BTW: CONFIG_NET_TCPBACKLOG probably should always be enabled. Otherwise, you will miss connection requests. That configuration is a candidate to be removed and just have connection backlog support enabled at all times.
@patacongo Thanks for the comment. I will modify our defconfigs in separate PR later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #21: net: tcp: Fix
compile error in tcp.h
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #21: net: tcp: Fix compile error in tcp.h
URL: https://github.com/apache/incubator-nuttx/pull/21
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services