You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Steve Hay <st...@uk.radan.com> on 2004/05/25 10:23:54 UTC
modperl/exit failing on Win32
modperl/exit test 2 fails in the current CVS w/ 2.0.49 + 5.8.4 on
Win32. Here's the output using -verbose:
# Failed test 2 in t/modperl/exit.t at line 18
# testing : exit in eval context
# expected: (?-xism:^ModPerl::Util::exit: exit was called)
# received: ModPerl::Util::exit: (120000) exit was called at
C:\Temp\modperl-2.0\t\response/TestModperl/exit.pm line 25
not ok 2
Where does that "(120000)" come from? Should the test just optionally
allow for it, or is it wrong?
Bizarrely, the same test runs fine in 1.99_14 (using the same Apache +
Perl).
- Steve
------------------------------------------------
Radan Computational Ltd.
The information contained in this message and any files transmitted with it are confidential and intended for the addressee(s) only. If you have received this message in error or there are any problems, please notify the sender immediately. The unauthorized use, disclosure, copying or alteration of this message is strictly forbidden. Note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of Radan Computational Ltd. The recipient(s) of this message should check it and any attached files for viruses: Radan Computational will accept no liability for any damage caused by any virus transmitted by this email.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [PATCH] Re: modperl/exit failing on Win32
Posted by Stas Bekman <st...@stason.org>.
Steve Hay wrote:
> Stas Bekman wrote:
>
>
>>Steve Hay wrote:
>>
>>
>>
>>>modperl/exit test 2 fails in the current CVS w/ 2.0.49 + 5.8.4 on
>>>Win32. Here's the output using -verbose:
>>>
>>># Failed test 2 in t/modperl/exit.t at line 18
>>># testing : exit in eval context
>>># expected: (?-xism:^ModPerl::Util::exit: exit was called)
>>># received: ModPerl::Util::exit: (120000) exit was called at
>>>C:\Temp\modperl-2.0\t\response/TestModperl/exit.pm line 25
>>>not ok 2
>>>
>>>Where does that "(120000)" come from? Should the test just optionally
>>>allow for it, or is it wrong?
>>>
>>>
>>
>>12000 is the value of ModPerl::EXIT exception constant. See:
>>http://perl.apache.org/docs/2.0/api/ModPerl/Util.html#C_exit_
>>
>>
>>
>>
>>>Bizarrely, the same test runs fine in 1.99_14 (using the same Apache +
>>>Perl).
>>>
>>>
>>
>>Sorry, I've added the error code to error messages in exceptions, w/o testing.
>> Should be fixed now.
>>
>
> OK, that explains it. There's still a slip in the test, though. Fixed
> by this:
>
> --- t/modperl/exit.t.orig 2004-05-25 09:48:35.000000000 +0100
> +++ t/modperl/exit.t 2004-05-25 11:04:16.101965000 +0100
> @@ -18,7 +18,7 @@
> {
> my $exit_excpt = ModPerl::EXIT;
> my $body = GET_BODY_ASSERT("$location?eval");
> - ok t_cmp(qr/^ModPerl::Util::exit: ($exit_excpt) exit was called/,
> + ok t_cmp(qr/^ModPerl::Util::exit: \($exit_excpt\) exit was called/,
> $body,
> "exit in eval context");
>
Yup, yup, now I was able to rebuild and test :) Thanks Steve!
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
[PATCH] Re: modperl/exit failing on Win32
Posted by Steve Hay <st...@uk.radan.com>.
Stas Bekman wrote:
>Steve Hay wrote:
>
>
>>modperl/exit test 2 fails in the current CVS w/ 2.0.49 + 5.8.4 on
>>Win32. Here's the output using -verbose:
>>
>># Failed test 2 in t/modperl/exit.t at line 18
>># testing : exit in eval context
>># expected: (?-xism:^ModPerl::Util::exit: exit was called)
>># received: ModPerl::Util::exit: (120000) exit was called at
>>C:\Temp\modperl-2.0\t\response/TestModperl/exit.pm line 25
>>not ok 2
>>
>>Where does that "(120000)" come from? Should the test just optionally
>>allow for it, or is it wrong?
>>
>>
>
>12000 is the value of ModPerl::EXIT exception constant. See:
>http://perl.apache.org/docs/2.0/api/ModPerl/Util.html#C_exit_
>
>
>
>>Bizarrely, the same test runs fine in 1.99_14 (using the same Apache +
>>Perl).
>>
>>
>
>Sorry, I've added the error code to error messages in exceptions, w/o testing.
> Should be fixed now.
>
OK, that explains it. There's still a slip in the test, though. Fixed
by this:
--- t/modperl/exit.t.orig 2004-05-25 09:48:35.000000000 +0100
+++ t/modperl/exit.t 2004-05-25 11:04:16.101965000 +0100
@@ -18,7 +18,7 @@
{
my $exit_excpt = ModPerl::EXIT;
my $body = GET_BODY_ASSERT("$location?eval");
- ok t_cmp(qr/^ModPerl::Util::exit: ($exit_excpt) exit was called/,
+ ok t_cmp(qr/^ModPerl::Util::exit: \($exit_excpt\) exit was called/,
$body,
"exit in eval context");
End of Patch.
------------------------------------------------
Radan Computational Ltd.
The information contained in this message and any files transmitted with it are confidential and intended for the addressee(s) only. If you have received this message in error or there are any problems, please notify the sender immediately. The unauthorized use, disclosure, copying or alteration of this message is strictly forbidden. Note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of Radan Computational Ltd. The recipient(s) of this message should check it and any attached files for viruses: Radan Computational will accept no liability for any damage caused by any virus transmitted by this email.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: modperl/exit failing on Win32
Posted by Stas Bekman <st...@stason.org>.
Steve Hay wrote:
> modperl/exit test 2 fails in the current CVS w/ 2.0.49 + 5.8.4 on
> Win32. Here's the output using -verbose:
>
> # Failed test 2 in t/modperl/exit.t at line 18
> # testing : exit in eval context
> # expected: (?-xism:^ModPerl::Util::exit: exit was called)
> # received: ModPerl::Util::exit: (120000) exit was called at
> C:\Temp\modperl-2.0\t\response/TestModperl/exit.pm line 25
> not ok 2
>
> Where does that "(120000)" come from? Should the test just optionally
> allow for it, or is it wrong?
12000 is the value of ModPerl::EXIT exception constant. See:
http://perl.apache.org/docs/2.0/api/ModPerl/Util.html#C_exit_
> Bizarrely, the same test runs fine in 1.99_14 (using the same Apache +
> Perl).
Sorry, I've added the error code to error messages in exceptions, w/o testing.
Should be fixed now. I'm still not in position to rebuild things. Will do
that tomorrow morning and fix any other related breakages I've caused.
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org